IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Dashboard scenes: Remove panel menu options that are dashboard editing activities when not in edit mode. (#84156)

Browse Source 
* remove panel menu options that are dasbhoard editing activities when the dashboard is not in edit mode

* remove corresponding keybindings when not in edit mode

* add keyboard shortcuts but inactivate them when not in edit mode

* Add tests; fix tests
This commit is contained in:
Oscar Kilhed
2024-03-11 11:33:33 +01:00
committed by GitHub
parent e8ecbaffc2
commit 87d6bebb9e
3 changed files with 103 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
public/app/features/dashboard-scene/scene/PanelMenuBehavior.test.tsx
View File

@@ -70,7 +70,7 @@ describe('panelMenuBehavior', () => {
await new Promise((r) => setTimeout(r, 1));
expect(menu.state.items?.length).toBe(8);
expect(menu.state.items?.length).toBe(6);
// verify view panel url keeps url params and adds viewPanel=<panel-key>
expect(menu.state.items?.[0].href).toBe('/d/dash-1?from=now-5m&to=now&viewPanel=panel-12');
// verify edit url keeps url time range
@@ -119,7 +119,7 @@ describe('panelMenuBehavior', () => {
await new Promise((r) => setTimeout(r, 1));
expect(menu.state.items?.length).toBe(9);
expect(menu.state.items?.length).toBe(7);
const extensionsSubMenu = menu.state.items?.find((i) => i.text === 'Extensions')?.subMenu;
@@ -158,7 +158,7 @@ describe('panelMenuBehavior', () => {
await new Promise((r) => setTimeout(r, 1));
expect(menu.state.items?.length).toBe(9);
expect(menu.state.items?.length).toBe(7);
const extensionsSubMenu = menu.state.items?.find((i) => i.text === 'Extensions')?.subMenu;
@@ -199,7 +199,7 @@ describe('panelMenuBehavior', () => {
await new Promise((r) => setTimeout(r, 1));
expect(menu.state.items?.length).toBe(9);
expect(menu.state.items?.length).toBe(7);
const extensionsSubMenu = menu.state.items?.find((i) => i.text === 'Extensions')?.subMenu;
const menuItem = extensionsSubMenu?.find((i) => (i.text = 'Declare incident when...'));
@@ -347,7 +347,7 @@ describe('panelMenuBehavior', () => {
await new Promise((r) => setTimeout(r, 1));
expect(menu.state.items?.length).toBe(9);
expect(menu.state.items?.length).toBe(7);
const extensionsSubMenu = menu.state.items?.find((i) => i.text === 'Extensions')?.subMenu;
@@ -392,7 +392,7 @@ describe('panelMenuBehavior', () => {
await new Promise((r) => setTimeout(r, 1));
expect(menu.state.items?.length).toBe(9);
expect(menu.state.items?.length).toBe(7);
const extensionsSubMenu = menu.state.items?.find((i) => i.text === 'Extensions')?.subMenu;
@@ -445,7 +445,7 @@ describe('panelMenuBehavior', () => {
await new Promise((r) => setTimeout(r, 1));
expect(menu.state.items?.length).toBe(9);
expect(menu.state.items?.length).toBe(7);
const extensionsSubMenu = menu.state.items?.find((i) => i.text === 'Extensions')?.subMenu;
@@ -470,6 +470,43 @@ describe('panelMenuBehavior', () => {
);
});
it('it should not contain remove and duplicate menu items when not in edit mode', async () => {
const { menu, panel } = await buildTestScene({});
panel.getPlugin = () => getPanelPlugin({ skipDataQuery: false });
mocks.contextSrv.hasAccessToExplore.mockReturnValue(true);
mocks.getExploreUrl.mockReturnValue(Promise.resolve('/explore'));
menu.activate();
await new Promise((r) => setTimeout(r, 1));
expect(menu.state.items?.find((i) => i.text === 'Remove')).toBeUndefined();
const moreMenu = menu.state.items?.find((i) => i.text === 'More...')?.subMenu;
expect(moreMenu?.find((i) => i.text === 'Duplicate')).toBeUndefined();
expect(moreMenu?.find((i) => i.text === 'Create library panel')).toBeUndefined();
});
it('it should contain remove and duplicate menu items when in edit mode', async () => {
const { scene, menu, panel } = await buildTestScene({});
scene.setState({ isEditing: true });
panel.getPlugin = () => getPanelPlugin({ skipDataQuery: false });
mocks.contextSrv.hasAccessToExplore.mockReturnValue(true);
mocks.getExploreUrl.mockReturnValue(Promise.resolve('/explore'));
menu.activate();
await new Promise((r) => setTimeout(r, 1));
expect(menu.state.items?.find((i) => i.text === 'Remove')).toBeDefined();
const moreMenu = menu.state.items?.find((i) => i.text === 'More...')?.subMenu;
expect(moreMenu?.find((i) => i.text === 'Duplicate')).toBeDefined();
expect(moreMenu?.find((i) => i.text === 'Create library panel')).toBeDefined();
});
it('should only contain explore when embedded', async () => {
const { menu, panel } = await buildTestScene({ isEmbedded: true });