IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Dashboards: Add duration to dashboard init tracking (#81637)

Browse Source 
* Add duration to dashboard init

* remove optional chaning, performance should be there

* Fix tests
This commit is contained in:
Oscar Kilhed 2024-02-01 15:52:27 +01:00 committed by GitHub
parent 89fb56bc11
commit 88feccf632
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
public/app/features/dashboard/state/initDashboard.ts
View File

@ -174,6 +174,8 @@ const getQueriesByDatasource = (
*/ */
export function initDashboard(args: InitDashboardArgs): ThunkResult<void> { export function initDashboard(args: InitDashboardArgs): ThunkResult<void> {
return async (dispatch, getState) => { return async (dispatch, getState) => {
const initStart = performance.now();
// set fetching state // set fetching state
dispatch(dashboardInitFetching()); dispatch(dashboardInitFetching());
@ -283,7 +285,8 @@ export function initDashboard(args: InitDashboardArgs): ThunkResult<void> {
}) })
); );
trackDashboardLoaded(dashboard, versionBeforeMigration); const duration = performance.now() - initStart;
trackDashboardLoaded(dashboard, duration, versionBeforeMigration);
// yay we are done // yay we are done
dispatch(dashboardInitCompleted(dashboard)); dispatch(dashboardInitCompleted(dashboard));

3
public/app/features/dashboard/utils/tracking.test.ts
View File

@ -33,9 +33,10 @@ describe('trackDashboardLoaded', () => {
const model = getDashboardModel(dashboardJSON); const model = getDashboardModel(dashboardJSON);
const reportInteractionSpy = jest.spyOn(runtime, 'reportInteraction'); const reportInteractionSpy = jest.spyOn(runtime, 'reportInteraction');
trackDashboardLoaded(model, 16); trackDashboardLoaded(model, 200, 16);
expect(reportInteractionSpy).toHaveBeenCalledWith('dashboards_init_dashboard_completed', { expect(reportInteractionSpy).toHaveBeenCalledWith('dashboards_init_dashboard_completed', {
duration: 200,
uid: 'dashboard-123', uid: 'dashboard-123',
title: 'Test Dashboard', title: 'Test Dashboard',
schemaVersion: model.schemaVersion, // This value is based on public/app/features/dashboard/state/DashboardMigrator.ts#L81 schemaVersion: model.schemaVersion, // This value is based on public/app/features/dashboard/state/DashboardMigrator.ts#L81

3
public/app/features/dashboard/utils/tracking.ts
View File

@ -2,7 +2,7 @@ import { DashboardInteractions } from 'app/features/dashboard-scene/utils/intera
import { DashboardModel } from '../state'; import { DashboardModel } from '../state';
export function trackDashboardLoaded(dashboard: DashboardModel, versionBeforeMigration?: number) { export function trackDashboardLoaded(dashboard: DashboardModel, duration: number, versionBeforeMigration?: number) {
// Count the different types of variables // Count the different types of variables
const variables = dashboard.templating.list const variables = dashboard.templating.list
.map((v) => v.type) .map((v) => v.type)
@ -30,6 +30,7 @@ export function trackDashboardLoaded(dashboard: DashboardModel, versionBeforeMig
...variables, ...variables,
settings_nowdelay: dashboard.timepicker.nowDelay, settings_nowdelay: dashboard.timepicker.nowDelay,
settings_livenow: !!dashboard.liveNow, settings_livenow: !!dashboard.liveNow,
duration,
}); });
} }