IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

A11y: Update buttons in Explore page to not use HTML Title for tooltip (#53894)

Browse Source
This commit is contained in:
eledobleefe
2022-08-22 11:19:22 +02:00
committed by GitHub
parent 51d173711f
commit 8cdfedc559
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
public/app/core/components/QueryOperationRow/QueryOperationAction.tsx
View File

@@ -26,7 +26,7 @@ export const QueryOperationAction: React.FC<QueryOperationActionProps> = ({
<div className={cx(styles.icon, active && styles.active)}> <div className={cx(styles.icon, active && styles.active)}>
<IconButton <IconButton
name={icon} name={icon}
title={title} tooltip={title}
className={styles.icon} className={styles.icon}
disabled={!!disabled} disabled={!!disabled}
onClick={onClick} onClick={onClick}

4
public/app/features/explore/ExploreToolbar.tsx
View File

@@ -155,11 +155,11 @@ class UnConnectedExploreToolbar extends PureComponent<Props> {
> >
<ToolbarButtonRow> <ToolbarButtonRow>
{!splitted ? ( {!splitted ? (
<ToolbarButton title="Split" onClick={() => split()} icon="columns" disabled={isLive}> <ToolbarButton tooltip="Split the pane" onClick={() => split()} icon="columns" disabled={isLive}>
Split Split
</ToolbarButton> </ToolbarButton>
) : ( ) : (
<ToolbarButton title="Close split pane" onClick={() => closeSplit(exploreId)} icon="times"> <ToolbarButton tooltip="Close split pane" onClick={() => closeSplit(exploreId)} icon="times">
Close Close
</ToolbarButton> </ToolbarButton>
)} )}

2
public/app/features/explore/QueryRows.test.tsx
View File

@@ -78,7 +78,7 @@ describe('Explore QueryRows', () => {
// waiting for the d&d component to fully render. // waiting for the d&d component to fully render.
await screen.findAllByText('someDs query editor'); await screen.findAllByText('someDs query editor');
let duplicateButton = screen.getByTitle('Duplicate query'); let duplicateButton = screen.getByLabelText(/Duplicate query/i);
fireEvent.click(duplicateButton); fireEvent.click(duplicateButton);

6
public/app/features/explore/Wrapper.test.tsx
View File

@@ -211,17 +211,17 @@ describe('Wrapper', () => {
}); });
}); });
it('can close a pane from a split', async () => { it('can close a panel from a split', async () => {
const urlParams = { const urlParams = {
left: JSON.stringify(['now-1h', 'now', 'loki', { refId: 'A' }]), left: JSON.stringify(['now-1h', 'now', 'loki', { refId: 'A' }]),
right: JSON.stringify(['now-1h', 'now', 'elastic', { refId: 'A' }]), right: JSON.stringify(['now-1h', 'now', 'elastic', { refId: 'A' }]),
}; };
setupExplore({ urlParams }); setupExplore({ urlParams });
const closeButtons = await screen.findAllByTitle(/Close split pane/i); const closeButtons = await screen.findAllByLabelText(/Close split pane/i);
await userEvent.click(closeButtons[1]); await userEvent.click(closeButtons[1]);
await waitFor(() => { await waitFor(() => {
const logsPanels = screen.queryAllByTitle(/Close split pane/i); const logsPanels = screen.queryAllByLabelText(/Close split pane/i);
expect(logsPanels.length).toBe(0); expect(logsPanels.length).toBe(0);
}); });
}); });