From 8d42e1b1697140a3fa538cf442779a3b9f836cdc Mon Sep 17 00:00:00 2001 From: Esteban Beltran Date: Tue, 25 Oct 2022 14:53:53 +0200 Subject: [PATCH] Toolkit: Deprecate node-version-check command (#57591) * Toolkit: Deprecate node-version-check command * Do not check for nodejs version on frontend-test --- package.json | 2 +- packages/grafana-toolkit/src/cli/index.ts | 11 +++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 54d5f77e062..1ab20922175 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,7 @@ "typecheck": "tsc --noEmit && yarn run packages:typecheck", "plugins:build-bundled": "grafana-toolkit plugin:bundle-managed", "watch": "yarn start -d watch,start core:start --watchTheme", - "ci:test-frontend": "yarn run test:ci && yarn grafana-toolkit node-version-check", + "ci:test-frontend": "yarn run test:ci", "postinstall": "husky install", "i18n:clean": "rimraf public/locales/en-US/grafana.json", "i18n:extract": "yarn i18n:clean && yarn run i18next -c public/locales/i18next-parser.config.js 'public/**/*.{tsx,ts}' 'packages/grafana-ui/**/*.{tsx,ts}' && node ./public/locales/psuedo.js", diff --git a/packages/grafana-toolkit/src/cli/index.ts b/packages/grafana-toolkit/src/cli/index.ts index 0490bd59cab..137265b6aa7 100644 --- a/packages/grafana-toolkit/src/cli/index.ts +++ b/packages/grafana-toolkit/src/cli/index.ts @@ -37,8 +37,15 @@ export const run = (includeInternalScripts = false) => { program .command('node-version-check') - .description('Verify node version') - .action(async (cmd) => { + .description('[deprecated] Verify node version') + .action(async () => { + chalk.yellow.bold( + `⚠️ This command is deprecated and will be removed in v10. No further support will be provided. ⚠️` + ); + console.log( + 'if you were reliant on this command we recommend https://www.npmjs.com/package/check-node-version' + ); + await execTask(nodeVersionCheckerTask)({}); });