IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Explore: query field should not propagate non-text change

Browse Source 
- after mounting with an initial value, the onChange of a query field is triggered
- even though the slate documents are not the same, their text values are identical, hence the change propagation is useless
- added check to propagate text change only when text has actually changed
This commit is contained in:
David Kaltschmidt 2019-01-29 15:53:51 +01:00
parent a803435b27
commit 8d44ed8d8f
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
public/app/features/explore/QueryField.tsx
View File

@ -128,17 +128,21 @@ export class QueryField extends React.PureComponent<QueryFieldProps, QueryFieldS
} }
onChange = ({ value }) => { onChange = ({ value }) => {
const textChanged = value.document !== this.state.value.document; const documentChanged = value.document !== this.state.value.document;
const prevValue = this.state.value;
// Control editor loop, then pass text change up to parent // Control editor loop, then pass text change up to parent
this.setState({ value }, () => { this.setState({ value }, () => {
if (textChanged) { if (documentChanged) {
this.handleChangeValue(); const textChanged = Plain.serialize(prevValue) !== Plain.serialize(value);
if (textChanged) {
this.handleChangeValue();
}
} }
}); });
// Show suggest menu on text input // Show suggest menu on text input
if (textChanged && value.selection.isCollapsed) { if (documentChanged && value.selection.isCollapsed) {
// Need one paint to allow DOM-based typeahead rules to work // Need one paint to allow DOM-based typeahead rules to work
window.requestAnimationFrame(this.handleTypeahead); window.requestAnimationFrame(this.handleTypeahead);
} else if (!this.resetTimer) { } else if (!this.resetTimer) {