Grafana-UI: Removes knobs still showing in storybook stories (#35381)

* Grafana-UI: Removes knobs from storybook addons pane * removed other knobs settings since we are disabling it * remove the knobs disable config in individual stories
2025-02-25 18:55:37 -06:00 · 2021-06-09 10:47:01 +01:00 · 2021-06-09 10:47:01 +01:00 · 8d9e1d75a5
commit 8d9e1d75a5
parent 873e20b7ae
44 changed files with 1 additions and 132 deletions
--- a/packages/grafana-ui/.storybook/preview.ts
+++ b/packages/grafana-ui/.storybook/preview.ts
@ -57,6 +57,6 @@ export const parameters = {
    },
  },
  knobs: {
-    escapeHTML: false,
+    disable: true,
  },
 };
--- a/packages/grafana-ui/src/components/Alert/Alert.story.tsx
+++ b/packages/grafana-ui/src/components/Alert/Alert.story.tsx
@ -17,9 +17,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
  },
  argTypes: {
    severity: { control: { type: 'select', options: severities } },
--- a/packages/grafana-ui/src/components/Badge/Badge.story.tsx
+++ b/packages/grafana-ui/src/components/Badge/Badge.story.tsx
@ -9,9 +9,6 @@ export default {
  decorators: [],
  parameters: {
    docs: {},
-    knobs: {
-      disable: true,
-    },
  },
  argTypes: {
    icon: { options: iconOptions, control: { type: 'select' } },
--- a/packages/grafana-ui/src/components/BarGauge/BarGauge.story.tsx
+++ b/packages/grafana-ui/src/components/BarGauge/BarGauge.story.tsx
@ -15,9 +15,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: [
        'theme',
--- a/packages/grafana-ui/src/components/BigValue/BigValue.story.tsx
+++ b/packages/grafana-ui/src/components/BigValue/BigValue.story.tsx
@ -21,9 +21,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['value', 'sparkline', 'onClick', 'className', 'alignmentFactors', 'text', 'count', 'theme'],
    },
--- a/packages/grafana-ui/src/components/Button/Button.story.tsx
+++ b/packages/grafana-ui/src/components/Button/Button.story.tsx
@ -14,9 +14,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
  },
 } as Meta;

--- a/packages/grafana-ui/src/components/ButtonCascader/ButtonCascader.story.tsx
+++ b/packages/grafana-ui/src/components/ButtonCascader/ButtonCascader.story.tsx
@ -9,9 +9,6 @@ export default {
  component: ButtonCascader,
  decorators: [withCenteredStory],
  parameters: {
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['className', 'value', 'fieldNames'],
    },
--- a/packages/grafana-ui/src/components/CallToActionCard/CallToActionCard.story.internal.tsx
+++ b/packages/grafana-ui/src/components/CallToActionCard/CallToActionCard.story.internal.tsx
@ -8,9 +8,6 @@ export default {
  title: 'Layout/CallToActionCard',
  component: CallToActionCard,
  parameters: {
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['className', 'callToActionElement', 'theme'],
    },
--- a/packages/grafana-ui/src/components/Card/Card.story.tsx
+++ b/packages/grafana-ui/src/components/Card/Card.story.tsx
@ -18,9 +18,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['onClick', 'href', 'heading', 'description', 'className'],
    },
--- a/packages/grafana-ui/src/components/Cascader/Cascader.story.tsx
+++ b/packages/grafana-ui/src/components/Cascader/Cascader.story.tsx
@ -39,9 +39,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['placeholder', 'initialValue', 'changeOnSelect'],
    },
--- a/packages/grafana-ui/src/components/ClipboardButton/ClipboardButton.story.internal.tsx
+++ b/packages/grafana-ui/src/components/ClipboardButton/ClipboardButton.story.internal.tsx
@ -13,9 +13,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['size', 'variant', 'icon', 'className', 'fullWidth'],
    },
--- a/packages/grafana-ui/src/components/ColorPicker/ColorPicker.story.tsx
+++ b/packages/grafana-ui/src/components/ColorPicker/ColorPicker.story.tsx
@ -17,9 +17,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['color', 'onChange', 'onColorChange'],
    },
--- a/packages/grafana-ui/src/components/ColorPicker/NamedColorsPalette.story.tsx
+++ b/packages/grafana-ui/src/components/ColorPicker/NamedColorsPalette.story.tsx
@ -12,9 +12,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['theme', 'color'],
    },
--- a/packages/grafana-ui/src/components/ConfirmButton/ConfirmButton.story.tsx
+++ b/packages/grafana-ui/src/components/ConfirmButton/ConfirmButton.story.tsx
@ -17,9 +17,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['className'],
    },
--- a/packages/grafana-ui/src/components/ConfirmModal/ConfirmModal.story.tsx
+++ b/packages/grafana-ui/src/components/ConfirmModal/ConfirmModal.story.tsx
@ -16,9 +16,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: defaultExcludes,
    },
--- a/packages/grafana-ui/src/components/Drawer/Drawer.story.tsx
+++ b/packages/grafana-ui/src/components/Drawer/Drawer.story.tsx
@ -14,9 +14,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
  },
  args: {
    closeOnMaskClick: true,
--- a/packages/grafana-ui/src/components/Dropdown/ButtonSelect.story.internal.tsx
+++ b/packages/grafana-ui/src/components/Dropdown/ButtonSelect.story.internal.tsx
@ -12,9 +12,6 @@ export default {
  component: ButtonSelect,
  decorators: [withCenteredStory],
  parameters: {
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['className', 'options', 'value', 'tooltipContent'],
    },
--- a/packages/grafana-ui/src/components/FormField/FormField.story.internal.tsx
+++ b/packages/grafana-ui/src/components/FormField/FormField.story.internal.tsx
@ -8,9 +8,6 @@ export default {
  component: FormField,
  decorators: [withCenteredStory],
  parameters: {
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['inputEl'],
    },
--- a/packages/grafana-ui/src/components/Forms/FieldValidationMessage.story.tsx
+++ b/packages/grafana-ui/src/components/Forms/FieldValidationMessage.story.tsx
@ -10,9 +10,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['className'],
    },
--- a/packages/grafana-ui/src/components/Forms/Form.story.tsx
+++ b/packages/grafana-ui/src/components/Forms/Form.story.tsx
@ -25,9 +25,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
  },
 };

--- a/packages/grafana-ui/src/components/Forms/Legacy/Input/Input.story.internal.tsx
+++ b/packages/grafana-ui/src/components/Forms/Legacy/Input/Input.story.internal.tsx
@ -11,9 +11,6 @@ export default {
  component: Input,
  decorators: [withCenteredStory],
  parameters: {
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['inputRef'],
    },
--- a/packages/grafana-ui/src/components/Forms/Legacy/Select/Select.story.internal.tsx
+++ b/packages/grafana-ui/src/components/Forms/Legacy/Select/Select.story.internal.tsx
@ -11,9 +11,6 @@ export default {
  component: Select,
  decorators: [withCenteredStory],
  parameters: {
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: [
        'className',
--- a/packages/grafana-ui/src/components/Forms/Legacy/Switch/Switch.story.internal.tsx
+++ b/packages/grafana-ui/src/components/Forms/Legacy/Switch/Switch.story.internal.tsx
@ -7,9 +7,6 @@ export default {
  title: 'Forms/Legacy/Switch',
  component: Switch,
  parameters: {
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['className', 'labelClass', 'switchClass'],
    },
--- a/packages/grafana-ui/src/components/Forms/Legend.story.tsx
+++ b/packages/grafana-ui/src/components/Forms/Legend.story.tsx
@ -11,9 +11,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['description'],
    },
--- a/packages/grafana-ui/src/components/Forms/RadioButtonGroup/RadioButtonGroup.story.tsx
+++ b/packages/grafana-ui/src/components/Forms/RadioButtonGroup/RadioButtonGroup.story.tsx
@ -10,9 +10,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['className', 'options', 'value'],
    },
--- a/packages/grafana-ui/src/components/Graph/Graph.story.tsx
+++ b/packages/grafana-ui/src/components/Graph/Graph.story.tsx
@ -81,9 +81,6 @@ export default {
  component: Graph,
  decorators: [withCenteredStory],
  parameters: {
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['className', 'ariaLabel'],
    },
--- a/packages/grafana-ui/src/components/Graph/GraphWithLegend.story.tsx
+++ b/packages/grafana-ui/src/components/Graph/GraphWithLegend.story.tsx
@ -11,9 +11,6 @@ export default {
  component: GraphWithLegend,
  decorator: [withCenteredStory],
  parameters: {
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['className', 'ariaLabel', 'legendDisplayMode'],
    },
--- a/packages/grafana-ui/src/components/GraphNG/GraphNG.story.tsx
+++ b/packages/grafana-ui/src/components/GraphNG/GraphNG.story.tsx
@ -13,9 +13,6 @@ export default {
  component: TimeSeries,
  decorators: [withCenteredStory],
  parameters: {
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['className', 'timeRange', 'data', 'legend', 'fields'],
    },
--- a/packages/grafana-ui/src/components/Input/Input.story.tsx
+++ b/packages/grafana-ui/src/components/Input/Input.story.tsx
@ -25,9 +25,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['prefix', 'suffix', 'addonBefore', 'addonAfter'],
    },
--- a/packages/grafana-ui/src/components/List/List.story.internal.tsx
+++ b/packages/grafana-ui/src/components/List/List.story.internal.tsx
@ -9,9 +9,6 @@ export default {
  title: 'Layout/List',
  component: List,
  parameters: {
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['renderItem', 'getItemKey', 'className', 'items'],
    },
--- a/packages/grafana-ui/src/components/Modal/Modal.story.tsx
+++ b/packages/grafana-ui/src/components/Modal/Modal.story.tsx
@ -17,9 +17,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['className', 'contentClassName', 'onDismiss', 'onClickBackdrop'],
    },
--- a/packages/grafana-ui/src/components/Pagination/Pagination.story.tsx
+++ b/packages/grafana-ui/src/components/Pagination/Pagination.story.tsx
@ -13,9 +13,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['currentPage', 'onNavigate'],
    },
--- a/packages/grafana-ui/src/components/SecretFormField/SecretFormField.story.internal.tsx
+++ b/packages/grafana-ui/src/components/SecretFormField/SecretFormField.story.internal.tsx
@ -14,9 +14,6 @@ export default {
    controls: {
      exclude: ['onReset'],
    },
-    knobs: {
-      disable: true,
-    },
  },
  argTypes: {
    labelWidth: { control: { type: 'range', min: 0, max: 30 } },
--- a/packages/grafana-ui/src/components/Select/Select.story.tsx
+++ b/packages/grafana-ui/src/components/Select/Select.story.tsx
@ -19,9 +19,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: [
        'getOptionValue',
--- a/packages/grafana-ui/src/components/Slider/RangeSlider.story.tsx
+++ b/packages/grafana-ui/src/components/Slider/RangeSlider.story.tsx
@ -10,9 +10,6 @@ export default {
    controls: {
      exclude: ['tooltipAlwaysVisible'],
    },
-    knobs: {
-      disable: true,
-    },
  },
  argTypes: {
    isStep: { name: 'step' },
--- a/packages/grafana-ui/src/components/Spinner/Spinner.story.tsx
+++ b/packages/grafana-ui/src/components/Spinner/Spinner.story.tsx
@ -16,9 +16,6 @@ export default {
    controls: {
      exclude: ['className', 'iconClassName', 'style', 'inline'],
    },
-    knobs: {
-      disable: true,
-    },
  },
  argTypes: {
    backgroundColor: { control: { type: 'color' } },
--- a/packages/grafana-ui/src/components/StatsPicker/StatsPicker.story.tsx
+++ b/packages/grafana-ui/src/components/StatsPicker/StatsPicker.story.tsx
@ -61,9 +61,6 @@ export default {
    controls: {
      exclude: ['onChange', 'stats', 'defaultStat', 'className'],
    },
-    knobs: {
-      disable: true,
-    },
  },
 } as Meta;

--- a/packages/grafana-ui/src/components/Switch/Switch.story.tsx
+++ b/packages/grafana-ui/src/components/Switch/Switch.story.tsx
@ -14,9 +14,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
  },
  args: {
    disabled: false,
--- a/packages/grafana-ui/src/components/Table/Table.story.tsx
+++ b/packages/grafana-ui/src/components/Table/Table.story.tsx
@ -27,9 +27,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
  },
  args: {
    width: 700,
--- a/packages/grafana-ui/src/components/TagsInput/TagsInput.story.tsx
+++ b/packages/grafana-ui/src/components/TagsInput/TagsInput.story.tsx
@ -14,9 +14,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['onChange', 'className', 'tags'],
    },
--- a/packages/grafana-ui/src/components/TextArea/TextArea.story.tsx
+++ b/packages/grafana-ui/src/components/TextArea/TextArea.story.tsx
@ -15,9 +15,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
  },
  argTypes: {
    containerWidth: { control: { type: 'range', min: 100, max: 500, step: 10 } },
--- a/packages/grafana-ui/src/components/ValuePicker/ValuePicker.story.tsx
+++ b/packages/grafana-ui/src/components/ValuePicker/ValuePicker.story.tsx
@ -15,9 +15,6 @@ export default {
    docs: {
      page: mdx,
    },
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['onChange', 'options'],
    },
--- a/packages/grafana-ui/src/components/VizLayout/VizLayout.story.tsx
+++ b/packages/grafana-ui/src/components/VizLayout/VizLayout.story.tsx
@ -9,9 +9,6 @@ export default {
  decorators: [withCenteredStory],
  parameters: {
    docs: {},
-    knobs: {
-      disable: true,
-    },
    controls: {
      exclude: ['legend'],
    },
--- a/packages/grafana-ui/src/components/VizLegend/VizLegend.story.tsx
+++ b/packages/grafana-ui/src/components/VizLegend/VizLegend.story.tsx
@ -11,11 +11,6 @@ export default {
  title: 'Visualizations/VizLegend',
  component: VizLegend,
  decorators: [withCenteredStory],
-  parameters: {
-    knobs: {
-      disable: true,
-    },
-  },
  args: {
    containerWidth: '100%',
    seriesCount: 5,