Plugins: Move plugin installing + uninstalling logic from CLI to plugins package (#33274)

* move guts from cli to server

* renaming + refactoring

* add pluginsDir arg

* arg fixes

* add support for repo URL override

* add funcs to interface

* use pluginID consistently

* swap args

* pass mandatory grafanaVersion field

* introduce logger interface

* create central logger for CLI

* add infra log wrapper

* re-add log initer step

* remove unused logger

* add checks for uninstalling

* improve debug blue

* make sure to close file

* fix linter issues

* remove space

* improve newline usage

* refactor packaging

* improve logger API

* fix interface func names

* close file and reformat zipslip catch

* handle G305 linter warning

* add helpful debug log
This commit is contained in:
Will Browne
2021-04-26 16:13:40 +02:00
committed by GitHub
parent d0239ac958
commit 8e6205c107
13 changed files with 874 additions and 16 deletions

View File

@@ -20,7 +20,7 @@ type CommandLine interface {
Generic(name string) interface{}
PluginDirectory() string
RepoDirectory() string
PluginRepoURL() string
PluginURL() string
}
@@ -54,7 +54,7 @@ func (c *ContextCommandLine) PluginDirectory() string {
return c.String("pluginsDir")
}
func (c *ContextCommandLine) RepoDirectory() string {
func (c *ContextCommandLine) PluginRepoURL() string {
return c.String("repo")
}