only push default datasources to the list if they're not undefined (#43966)

This commit is contained in:
Ashley Harrison 2022-01-13 09:26:26 +00:00 committed by GitHub
parent bf417be2e0
commit 8f1468df6a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -268,15 +268,24 @@ export class DatasourceSrv implements DataSourceService {
if (!filters.pluginId && !filters.alerting) { if (!filters.pluginId && !filters.alerting) {
if (filters.mixed) { if (filters.mixed) {
base.push(this.getInstanceSettings('-- Mixed --')!); const mixedInstanceSettings = this.getInstanceSettings('-- Mixed --');
if (mixedInstanceSettings) {
base.push(mixedInstanceSettings);
}
} }
if (filters.dashboard) { if (filters.dashboard) {
base.push(this.getInstanceSettings('-- Dashboard --')!); const dashboardInstanceSettings = this.getInstanceSettings('-- Dashboard --');
if (dashboardInstanceSettings) {
base.push(dashboardInstanceSettings);
}
} }
if (!filters.tracing) { if (!filters.tracing) {
base.push(this.getInstanceSettings('-- Grafana --')!); const grafanaInstanceSettings = this.getInstanceSettings('-- Grafana --');
if (grafanaInstanceSettings) {
base.push(grafanaInstanceSettings);
}
} }
} }