IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-11 16:15:42 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Replace VerticalGroup in OrgDetailsPage and BenchmarksPage (#86621)

Browse Source
This commit is contained in:
Joao Silva 2024-04-19 16:28:51 +01:00 committed by GitHub
parent db4f7cd21d
commit 8f38ef70ce
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.betterer.results
View File

@ -3961,9 +3961,6 @@ exports[`better eslint`] = {
"public/app/features/migrate-to-cloud/api/index.ts:5381": [
[0, 0, 0, "Do not use export all (\`export * from ...\`)", "0"]
],
"public/app/features/org/OrgDetailsPage.tsx:5381": [
[0, 0, 0, "\'VerticalGroup\' import from \'@grafana/ui\' is restricted from being used by a pattern. Use Stack component instead.", "0"]
],
"public/app/features/org/state/actions.ts:5381": [
[0, 0, 0, "Unexpected any. Specify a different type.", "0"]
],
@ -4220,9 +4217,6 @@ exports[`better eslint`] = {
[0, 0, 0, "Unexpected any. Specify a different type.", "9"],
[0, 0, 0, "Unexpected any. Specify a different type.", "10"]
],
"public/app/features/sandbox/BenchmarksPage.tsx:5381": [
[0, 0, 0, "\'VerticalGroup\' import from \'@grafana/ui\' is restricted from being used by a pattern. Use Stack component instead.", "0"]
],
"public/app/features/search/page/components/ActionRow.tsx:5381": [
[0, 0, 0, "Styles should be written using objects.", "0"],
[0, 0, 0, "Styles should be written using objects.", "1"]

6
public/app/features/org/OrgDetailsPage.tsx
View File

@ -1,7 +1,7 @@
import React, { PureComponent } from 'react';
import { ConnectedProps, connect } from 'react-redux';
import { VerticalGroup } from '@grafana/ui';
import { Stack } from '@grafana/ui';
import { Page } from 'app/core/components/Page/Page';
import SharedPreferences from 'app/core/components/SharedPreferences/SharedPreferences';
import { appEvents, contextSrv } from 'app/core/core';
@ -51,7 +51,7 @@ export class OrgDetailsPage extends PureComponent<Props> {
<Page navModel={navModel}>
<Page.Contents isLoading={isLoading}>
{!isLoading && (
<VerticalGroup spacing="lg">
<Stack direction="column" gap={3}>
{canReadOrg && <OrgProfile onSubmit={this.onUpdateOrganization} orgName={organization.name} />}
{canReadPreferences && (
<SharedPreferences
@ -61,7 +61,7 @@ export class OrgDetailsPage extends PureComponent<Props> {
onConfirm={this.handleConfirm}
/>
)}
</VerticalGroup>
</Stack>
)}
</Page.Contents>
</Page>

7
public/app/features/sandbox/BenchmarksPage.tsx
View File

@ -1,14 +1,9 @@
import React from 'react';
import { VerticalGroup } from '@grafana/ui';
import { EmotionPerfTest } from '@grafana/ui/src/components/ThemeDemos/EmotionPerfTest';
export const BenchmarksPage = () => {
return (
<VerticalGroup>
<EmotionPerfTest />
</VerticalGroup>
);
return <EmotionPerfTest />;
};
export default BenchmarksPage;