IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

POC: Refresh footer on SaveDashboardAsForm when title and folder data change by the user (#92330)

Browse Source
This commit is contained in:
Laura Fernández 2024-09-11 11:51:48 +02:00 committed by GitHub
parent f88571c2e7
commit 902c658c9a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
public/app/features/dashboard-scene/saving/SaveDashboardAsForm.tsx
View File

@ -1,5 +1,5 @@
import debounce from 'debounce-promise';
import { ChangeEvent } from 'react';
import { ChangeEvent, useState } from 'react';
import { UseFormSetValue, useForm } from 'react-hook-form';
import { selectors } from '@grafana/e2e-selectors';
@ -47,6 +47,7 @@ export function SaveDashboardAsForm({ dashboard, changeInfo }: Props) {
const { state, onSaveDashboard } = useSaveDashboard(false);
const [contentSent, setContentSent] = useState<{ title?: string; folderUid?: string }>({});
const onSave = async (overwrite: boolean) => {
const data = getValues();
@ -55,6 +56,11 @@ export function SaveDashboardAsForm({ dashboard, changeInfo }: Props) {
if (result.status === 'success') {
dashboard.closeModal();
} else {
setContentSent({
title: data.title,
folderUid: data.folder.uid,
});
}
};
@ -69,15 +75,16 @@ export function SaveDashboardAsForm({ dashboard, changeInfo }: Props) {
);
function renderFooter(error?: Error) {
if (isNameExistsError(error)) {
const formValuesMatchContentSent =
formValues.title.trim() === contentSent.title && formValues.folder.uid === contentSent.folderUid;
if (isNameExistsError(error) && formValuesMatchContentSent) {
return <NameAlreadyExistsError cancelButton={cancelButton} saveButton={saveButton} />;
}
return (
<>
{error && (
{error && formValuesMatchContentSent && (
<Alert title="Failed to save dashboard" severity="error">
<p>{error.message}</p>
{error.message && <p>{error.message}</p>}
</Alert>
)}
<Stack alignItems="center">
@ -118,7 +125,9 @@ export function SaveDashboardAsForm({ dashboard, changeInfo }: Props) {
<Field label="Folder">
<FolderPicker
onChange={(uid: string | undefined, title: string | undefined) => setValue('folder', { uid, title })}
onChange={(uid: string | undefined, title: string | undefined) => {
setValue('folder', { uid, title });
}}
// Old folder picker fields
value={formValues.folder?.uid}
initialTitle={defaultValues!.folder!.title}