IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

tech(cli): dont use defer statements in loops

Browse Source
This commit is contained in:
bergquist 2016-04-19 09:13:58 +02:00
parent 5abaf26b5f
commit 903d1b7797
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/cmd/grafana-cli/commands/install_command.go
View File

@ -164,14 +164,14 @@ func downloadFile(pluginName, filePath, url string) (err error) {
return fmt.Errorf(permissionsDeniedMessage, newFile) return fmt.Errorf(permissionsDeniedMessage, newFile)
} }
defer dst.Close()
src, err := zf.Open() src, err := zf.Open()
if err != nil { if err != nil {
log.Errorf("%v", err) log.Errorf("%v", err)
} }
defer src.Close()
io.Copy(dst, src) io.Copy(dst, src)
dst.Close()
src.Close()
} }
} }