IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Tempo: Improve UX of service graph related warnings (#76134)

Browse Source 
Improve UX of service graph related warnings
This commit is contained in:
Joey
2023-10-11 09:43:05 +01:00
committed by GitHub
parent dc8b07d46f
commit 9101eb219c
1 changed files with 33 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
public/app/plugins/datasource/tempo/ServiceGraphSection.tsx
View File

@@ -53,15 +53,18 @@ export function ServiceGraphSection({
const ds = dsState.value as PrometheusDatasource;
if (!graphDatasourceUid) {
return <div className="text-warning">Please set up a service graph datasource in the datasource settings.</div>;
return getWarning(
'No service graph datasource selected',
'Please set up a service graph datasource in the datasource settings',
styles
);
}
if (graphDatasourceUid && !ds) {
return (
<div className="text-warning">
Service graph datasource is configured but the data source no longer exists. Please configure existing data
source to use the service graph functionality.
</div>
return getWarning(
'No service graph data found',
'Service graph datasource is configured but the data source no longer exists. Please configure existing data source to use the service graph functionality',
styles
);
}
@@ -101,24 +104,34 @@ export function ServiceGraphSection({
/>
</InlineField>
</InlineFieldRow>
{hasKeys === false ? (
<Alert title="No service graph data found" severity="info" className={styles.alert}>
Please ensure that service graph metrics are set up correctly according to the{' '}
<a
target="_blank"
rel="noreferrer noopener"
href="https://grafana.com/docs/grafana/latest/datasources/tempo/#service-graph"
className={styles.link}
>
Tempo documentation
</a>
.
</Alert>
) : null}
{hasKeys === false
? getWarning(
'No service graph data found',
'Please ensure that service graph metrics are set up correctly',
styles
)
: null}
</div>
);
}
function getWarning(title: string, description: string, styles: { alert: string; link: string }) {
return (
<Alert title={title} severity="info" className={styles.alert}>
{description} according to the{' '}
<a
target="_blank"
rel="noreferrer noopener"
href="https://grafana.com/docs/grafana/latest/datasources/tempo/service-graph/"
className={styles.link}
>
Tempo documentation
</a>
.
</Alert>
);
}
function queryToFilter(query: string): AdHocVariableFilter[] {
let match;
let filters: AdHocVariableFilter[] = [];