IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Unsubscribe from events in dashboards (#19788)

Browse Source 
* Unsubscribe on unmount

* Fix unsubscribe
This commit is contained in:
Andrej Ocenas 2019-10-16 12:54:13 +02:00 committed by GitHub
parent f8c474fa1b
commit 945b815fe0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
public/app/features/dashboard/dashgrid/PanelChrome.tsx
View File

@ -81,6 +81,8 @@ export class PanelChrome extends PureComponent<Props, State> {
componentWillUnmount() { componentWillUnmount() {
this.props.panel.events.off(PanelEvents.refresh, this.onRefresh); this.props.panel.events.off(PanelEvents.refresh, this.onRefresh);
this.props.panel.events.off(PanelEvents.render, this.onRender);
if (this.querySubscription) { if (this.querySubscription) {
this.querySubscription.unsubscribe(); this.querySubscription.unsubscribe();
this.querySubscription = null; this.querySubscription = null;

3
public/app/features/dashboard/panel_editor/VisualizationTab.tsx
View File

@ -151,6 +151,9 @@ export class VisualizationTab extends PureComponent<Props, State> {
} }
componentWillUnmount() { componentWillUnmount() {
if (this.querySubscription) {
this.querySubscription.unsubscribe();
}
this.cleanUpAngularOptions(); this.cleanUpAngularOptions();
} }