From 946e54241297ef171c5bdf4199de393d38854f2f Mon Sep 17 00:00:00 2001
From: "Woodward, Joshua" <jwwoodward@ebay.com>
Date: Thu, 7 Mar 2019 14:00:04 -0800
Subject: [PATCH] Make password hint configurable from settings/defaults.ini

---
 conf/defaults.ini                         | 1 +
 pkg/api/login.go                          | 1 +
 pkg/setting/setting.go                    | 2 ++
 public/app/core/config.ts                 | 1 +
 public/app/core/controllers/login_ctrl.ts | 1 +
 public/app/partials/login.html            | 2 +-
 6 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/conf/defaults.ini b/conf/defaults.ini
index df02e01235b..33fe17a2aa6 100644
--- a/conf/defaults.ini
+++ b/conf/defaults.ini
@@ -231,6 +231,7 @@ verify_email_enabled = false
 
 # Background text for the user field on the login page
 login_hint = email or username
+passowrd_hint = password
 
 # Default UI theme ("dark" or "light")
 default_theme = dark
diff --git a/pkg/api/login.go b/pkg/api/login.go
index 1445463852b..f6c3e802988 100644
--- a/pkg/api/login.go
+++ b/pkg/api/login.go
@@ -36,6 +36,7 @@ func (hs *HTTPServer) LoginView(c *m.ReqContext) {
 	viewData.Settings["oauth"] = enabledOAuths
 	viewData.Settings["disableUserSignUp"] = !setting.AllowUserSignUp
 	viewData.Settings["loginHint"] = setting.LoginHint
+	viewData.Settings["passwordHint"] = setting.PasswordHint
 	viewData.Settings["disableLoginForm"] = setting.DisableLoginForm
 
 	if loginError, ok := tryGetEncryptedCookie(c, LoginErrorCookieName); ok {
diff --git a/pkg/setting/setting.go b/pkg/setting/setting.go
index 5d44a3585dc..7b6e99255aa 100644
--- a/pkg/setting/setting.go
+++ b/pkg/setting/setting.go
@@ -109,6 +109,7 @@ var (
 	AutoAssignOrgRole       string
 	VerifyEmailEnabled      bool
 	LoginHint               string
+	PasswordHint            string
 	DefaultTheme            string
 	DisableLoginForm        bool
 	DisableSignoutMenu      bool
@@ -656,6 +657,7 @@ func (cfg *Cfg) Load(args *CommandLineArgs) error {
 	AutoAssignOrgRole = users.Key("auto_assign_org_role").In("Editor", []string{"Editor", "Admin", "Viewer"})
 	VerifyEmailEnabled = users.Key("verify_email_enabled").MustBool(false)
 	LoginHint = users.Key("login_hint").String()
+	PasswordHint = users.Key("password_hint").String()
 	DefaultTheme = users.Key("default_theme").String()
 	ExternalUserMngLinkUrl = users.Key("external_manage_link_url").String()
 	ExternalUserMngLinkName = users.Key("external_manage_link_name").String()
diff --git a/public/app/core/config.ts b/public/app/core/config.ts
index 8fefc1aeb0a..bbf7fb88d62 100644
--- a/public/app/core/config.ts
+++ b/public/app/core/config.ts
@@ -34,6 +34,7 @@ export class Settings {
   oauth: any;
   disableUserSignUp: boolean;
   loginHint: any;
+  passwordHint: any;
   loginError: any;
   viewersCanEdit: boolean;
   editorsCanOwn: boolean;
diff --git a/public/app/core/controllers/login_ctrl.ts b/public/app/core/controllers/login_ctrl.ts
index de4e3415dfb..3a72379aa81 100644
--- a/public/app/core/controllers/login_ctrl.ts
+++ b/public/app/core/controllers/login_ctrl.ts
@@ -25,6 +25,7 @@ export class LoginCtrl {
     $scope.disableLoginForm = config.disableLoginForm;
     $scope.disableUserSignUp = config.disableUserSignUp;
     $scope.loginHint = config.loginHint;
+    $scope.passwordHint = config.passwordHint;
 
     $scope.loginMode = true;
     $scope.submitBtnText = 'Log in';
diff --git a/public/app/partials/login.html b/public/app/partials/login.html
index 674c9581ce5..33872c7d6d5 100644
--- a/public/app/partials/login.html
+++ b/public/app/partials/login.html
@@ -13,7 +13,7 @@
           </div>
           <div class="login-form">
             <input type="password" name="password" class="gf-form-input login-form-input" required ng-model="formModel.password" id="inputPassword"
-              placeholder="password">
+              placeholder="{{passwordHint}}">
           </div>
           <div class="login-button-group">
             <button type="submit" class="btn btn-large p-x-2" ng-if="!loggingIn" ng-click="submit();" ng-class="{'btn-inverse': !loginForm.$valid, 'btn-primary': loginForm.$valid}">