From 95d379368a87dbb24bd37f404226193f85bb7833 Mon Sep 17 00:00:00 2001 From: Alex Khomenko Date: Tue, 1 Oct 2024 13:23:21 +0300 Subject: [PATCH] Announcement banner: Enable feature toggle by default (#94041) * Announcement banner: Enable by default * Update feature stage --- .../feature-toggles/index.md | 2 +- pkg/services/featuremgmt/registry.go | 3 +- pkg/services/featuremgmt/toggles_gen.csv | 2 +- pkg/services/featuremgmt/toggles_gen.json | 42 ++++++++++--------- 4 files changed, 27 insertions(+), 22 deletions(-) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index 2b3b25d5a08..7b536cf07d2 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -72,6 +72,7 @@ Most [generally available](https://grafana.com/docs/release-life-cycle/#general- | `tlsMemcached` | Use TLS-enabled memcached in the enterprise caching feature | Yes | | `cloudWatchNewLabelParsing` | Updates CloudWatch label parsing to be more accurate | Yes | | `newDashboardSharingComponent` | Enables the new sharing drawer design | | +| `notificationBanner` | Enables the notification banner UI and API | Yes | | `pluginProxyPreserveTrailingSlash` | Preserve plugin proxy trailing slash. | | | `openSearchBackendFlowEnabled` | Enables the backend query flow for Open Search datasource plugin | Yes | | `cloudWatchRoundUpEndTime` | Round up end time for metric queries to the next minute to avoid missing data | Yes | @@ -186,7 +187,6 @@ Experimental features might be changed or removed without prior notice. | `queryLibrary` | Enables Query Library feature in Explore | | `logsExploreTableDefaultVisualization` | Sets the logs table as default visualisation in logs explore | | `alertingListViewV2` | Enables the new alert list view design | -| `notificationBanner` | Enables the notification banner UI and API | | `dashboardRestore` | Enables deleted dashboard restore feature (backend only) | | `alertingCentralAlertHistory` | Enables the new central alert history. | | `pinNavItems` | Enables pinning of nav items | diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index b2eefd0622b..84c26aba608 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -1237,9 +1237,10 @@ var ( { Name: "notificationBanner", Description: "Enables the notification banner UI and API", - Stage: FeatureStageExperimental, + Stage: FeatureStageGeneralAvailability, Owner: grafanaFrontendPlatformSquad, FrontendOnly: false, + Expression: "true", }, { Name: "dashboardRestore", diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index ffdf26a0e3c..b11709ae1b1 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -161,7 +161,7 @@ queryLibrary,experimental,@grafana/explore-squad,false,false,false logsExploreTableDefaultVisualization,experimental,@grafana/observability-logs,false,false,true newDashboardSharingComponent,GA,@grafana/sharing-squad,false,false,true alertingListViewV2,experimental,@grafana/alerting-squad,false,false,true -notificationBanner,experimental,@grafana/grafana-frontend-platform,false,false,false +notificationBanner,GA,@grafana/grafana-frontend-platform,false,false,false dashboardRestore,experimental,@grafana/search-and-storage,false,false,false datasourceProxyDisableRBAC,GA,@grafana/identity-access-team,false,false,false alertingDisableSendAlertsExternal,experimental,@grafana/alerting-squad,false,false,false diff --git a/pkg/services/featuremgmt/toggles_gen.json b/pkg/services/featuremgmt/toggles_gen.json index 0868229e1c7..1430f24481a 100644 --- a/pkg/services/featuremgmt/toggles_gen.json +++ b/pkg/services/featuremgmt/toggles_gen.json @@ -2108,13 +2108,17 @@ { "metadata": { "name": "notificationBanner", - "resourceVersion": "1718727528075", - "creationTimestamp": "2024-05-13T09:32:34Z" + "resourceVersion": "1727777007488", + "creationTimestamp": "2024-05-13T09:32:34Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-10-01 10:03:27.48823 +0000 UTC" + } }, "spec": { "description": "Enables the notification banner UI and API", - "stage": "experimental", - "codeowner": "@grafana/grafana-frontend-platform" + "stage": "GA", + "codeowner": "@grafana/grafana-frontend-platform", + "expression": "true" } }, { @@ -2999,6 +3003,20 @@ "requiresRestart": true } }, + { + "metadata": { + "name": "unifiedStorageSearch", + "resourceVersion": "1726771421439", + "creationTimestamp": "2024-09-19T18:43:41Z" + }, + "spec": { + "description": "Enable unified storage search", + "stage": "experimental", + "codeowner": "@grafana/search-and-storage", + "hideFromAdminPage": true, + "hideFromDocs": true + } + }, { "metadata": { "name": "useSeessionStorageForRedirection", @@ -3024,20 +3042,6 @@ "codeowner": "@grafana/identity-access-team" } }, - { - "metadata": { - "name": "unifiedStorageSearch", - "resourceVersion": "1726771421439", - "creationTimestamp": "2024-09-19T18:43:41Z" - }, - "spec": { - "description": "Enable unified storage search", - "stage": "experimental", - "codeowner": "@grafana/search-and-storage", - "hideFromAdminPage": true, - "hideFromDocs": true - } - }, { "metadata": { "name": "vizActions", @@ -3092,4 +3096,4 @@ } } ] -} +} \ No newline at end of file