IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Alerting: Fix UI crashing when selecting custom grouping in alert panel (#64124)

Browse Source 
Fix UI crashing when selecting custom grouping in alert panel
This commit is contained in:
Sonia Aguilar 2023-03-03 12:59:36 +01:00 committed by GitHub
parent c840f6fb9d
commit 9765c98b3d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
public/app/plugins/panel/alertlist/GroupByWithLoading.tsx
View File

@ -5,7 +5,6 @@ import { SelectableValue } from '@grafana/data';
import { Icon, MultiSelect } from '@grafana/ui';
import { useUnifiedAlertingSelector } from 'app/features/alerting/unified/hooks/useUnifiedAlertingSelector';
import { fetchAllPromRulesAction } from 'app/features/alerting/unified/state/actions';
import { getAllRulesSourceNames } from 'app/features/alerting/unified/utils/datasource';
import {
isAsyncRequestMapSlicePending,
isAsyncRequestMapSliceSettled,
@ -31,7 +30,6 @@ export const GroupBy: FC<Props> = (props) => {
}, [dispatch]);
const promRulesByDatasource = useUnifiedAlertingSelector((state) => state.promRules);
const rulesDataSourceNames = useMemo(getAllRulesSourceNames, []);
const allRequestsReady = isAsyncRequestMapSliceSettled(promRulesByDatasource);
const loading = isAsyncRequestMapSlicePending(promRulesByDatasource);
@ -45,7 +43,7 @@ export const GroupBy: FC<Props> = (props) => {
return [];
}
const allLabels = rulesDataSourceNames
const allLabels = Object.keys(promRulesByDatasource)
.flatMap((datasource) => promRulesByDatasource[datasource].result ?? [])
.flatMap((rules) => rules.groups)
.flatMap((group) => group.rules.filter((rule): rule is AlertingRule => rule.type === PromRuleType.Alerting))
@ -54,7 +52,7 @@ export const GroupBy: FC<Props> = (props) => {
.flatMap((labels) => labels.filter(isPrivateLabel));
return uniq(allLabels);
}, [allRequestsReady, promRulesByDatasource, rulesDataSourceNames]);
}, [allRequestsReady, promRulesByDatasource]);
return (
<MultiSelect<string>