diff --git a/public/app/features/dashboard/dashgrid/AddPanelPanel.tsx b/public/app/features/dashboard/dashgrid/AddPanelPanel.tsx index 68cee112f42..12c6185edfe 100644 --- a/public/app/features/dashboard/dashgrid/AddPanelPanel.tsx +++ b/public/app/features/dashboard/dashgrid/AddPanelPanel.tsx @@ -197,6 +197,7 @@ export class AddPanelPanel extends React.Component { beforeEach(() => { config.panels = [ getPanelPlugin({ id: 'singlestat', sort: 2 }), - getPanelPlugin({ id: 'hiddem', sort: 100, hideFromList: true }), + getPanelPlugin({ id: 'hidden', sort: 100, hideFromList: true }), getPanelPlugin({ id: 'graph', sort: 1 }), getPanelPlugin({ id: 'alexander_zabbix', sort: 100 }), getPanelPlugin({ id: 'piechart', sort: 100 }), @@ -33,16 +33,14 @@ describe('AddPanelPanel', () => { }); it('should fetch all panels sorted with core plugins first', () => { - //console.log(wrapper.debug()); - //console.log(wrapper.find('.add-panel__item').get(0).props.title); - expect(wrapper.find('.add-panel__item').get(1).props.title).toBe('Singlestat'); - expect(wrapper.find('.add-panel__item').get(4).props.title).toBe('Piechart'); + expect(wrapper.find('.add-panel__item').get(1).props.title).toBe('singlestat'); + expect(wrapper.find('.add-panel__item').get(4).props.title).toBe('piechart'); }); it('should filter', () => { wrapper.find('input').simulate('change', { target: { value: 'p' } }); - expect(wrapper.find('.add-panel__item').get(1).props.title).toBe('Piechart'); - expect(wrapper.find('.add-panel__item').get(0).props.title).toBe('Graph'); + expect(wrapper.find('.add-panel__item').get(1).props.title).toBe('piechart'); + expect(wrapper.find('.add-panel__item').get(0).props.title).toBe('graph'); }); }); diff --git a/public/app/features/datasources/settings/__snapshots__/DataSourceSettings.test.tsx.snap b/public/app/features/datasources/settings/__snapshots__/DataSourceSettings.test.tsx.snap index ebb856ca354..f95055c9095 100644 --- a/public/app/features/datasources/settings/__snapshots__/DataSourceSettings.test.tsx.snap +++ b/public/app/features/datasources/settings/__snapshots__/DataSourceSettings.test.tsx.snap @@ -65,7 +65,11 @@ exports[`Render should render alpha info text 1`] = ` "large": "large/logo", "small": "small/logo", }, - "screenshots": "screenshot/1", + "screenshots": Array [ + Object { + "path": "screenshot", + }, + ], "updated": "2018-09-26", "version": "1", }, @@ -158,7 +162,11 @@ exports[`Render should render beta info text 1`] = ` "large": "large/logo", "small": "small/logo", }, - "screenshots": "screenshot/1", + "screenshots": Array [ + Object { + "path": "screenshot", + }, + ], "updated": "2018-09-26", "version": "1", }, @@ -246,7 +254,11 @@ exports[`Render should render component 1`] = ` "large": "large/logo", "small": "small/logo", }, - "screenshots": "screenshot/1", + "screenshots": Array [ + Object { + "path": "screenshot", + }, + ], "updated": "2018-09-26", "version": "1", }, @@ -339,7 +351,11 @@ exports[`Render should render is ready only message 1`] = ` "large": "large/logo", "small": "small/logo", }, - "screenshots": "screenshot/1", + "screenshots": Array [ + Object { + "path": "screenshot", + }, + ], "updated": "2018-09-26", "version": "1", }, diff --git a/public/app/features/plugins/__mocks__/pluginMocks.ts b/public/app/features/plugins/__mocks__/pluginMocks.ts index eceb2887cc4..358adb112b3 100644 --- a/public/app/features/plugins/__mocks__/pluginMocks.ts +++ b/public/app/features/plugins/__mocks__/pluginMocks.ts @@ -34,33 +34,25 @@ export const getMockPlugins = (amount: number): Plugin[] => { }; export const getPanelPlugin = (options: { id: string; sort?: number; hideFromList?: boolean }): PanelPlugin => { - const info = { - author: { - name: options.id + 'name', - }, - description: '', - links: [], - logos: { - large: '', - small: '', - }, - screenshots: [], - updated: '', - version: '', - }; - return { id: options.id, name: options.id, sort: options.sort || 1, - meta: { - id: options.id, - name: options.id, - info: info, - includes: [], + info: { + author: { + name: options.id + 'name', + }, + description: '', + links: [], + logos: { + large: '', + small: '', + }, + screenshots: [], + updated: '', + version: '', }, - info: info, - hideFromList: options.hideFromList, + hideFromList: options.hideFromList === true, module: '', baseUrl: '', }; diff --git a/public/app/features/plugins/__snapshots__/PluginList.test.tsx.snap b/public/app/features/plugins/__snapshots__/PluginList.test.tsx.snap index 5eb82fbefb6..160c02c6e8e 100644 --- a/public/app/features/plugins/__snapshots__/PluginList.test.tsx.snap +++ b/public/app/features/plugins/__snapshots__/PluginList.test.tsx.snap @@ -28,7 +28,11 @@ exports[`Render should render component 1`] = ` "large": "large/logo", "small": "small/logo", }, - "screenshots": "screenshot/0", + "screenshots": Array [ + Object { + "path": "screenshot/0", + }, + ], "updated": "2018-09-26", "version": "1", }, @@ -62,7 +66,11 @@ exports[`Render should render component 1`] = ` "large": "large/logo", "small": "small/logo", }, - "screenshots": "screenshot/1", + "screenshots": Array [ + Object { + "path": "screenshot/1", + }, + ], "updated": "2018-09-26", "version": "1", }, @@ -96,7 +104,11 @@ exports[`Render should render component 1`] = ` "large": "large/logo", "small": "small/logo", }, - "screenshots": "screenshot/2", + "screenshots": Array [ + Object { + "path": "screenshot/2", + }, + ], "updated": "2018-09-26", "version": "1", }, @@ -130,7 +142,11 @@ exports[`Render should render component 1`] = ` "large": "large/logo", "small": "small/logo", }, - "screenshots": "screenshot/3", + "screenshots": Array [ + Object { + "path": "screenshot/3", + }, + ], "updated": "2018-09-26", "version": "1", }, @@ -164,7 +180,11 @@ exports[`Render should render component 1`] = ` "large": "large/logo", "small": "small/logo", }, - "screenshots": "screenshot/4", + "screenshots": Array [ + Object { + "path": "screenshot/4", + }, + ], "updated": "2018-09-26", "version": "1", }, @@ -198,7 +218,11 @@ exports[`Render should render component 1`] = ` "large": "large/logo", "small": "small/logo", }, - "screenshots": "screenshot/5", + "screenshots": Array [ + Object { + "path": "screenshot/5", + }, + ], "updated": "2018-09-26", "version": "1", }, diff --git a/public/app/features/plugins/plugin_component.ts b/public/app/features/plugins/plugin_component.ts index 2fe25c4666d..fc11d8d98ec 100644 --- a/public/app/features/plugins/plugin_component.ts +++ b/public/app/features/plugins/plugin_component.ts @@ -5,8 +5,6 @@ import config from 'app/core/config'; import coreModule from 'app/core/core_module'; import { importPluginModule } from './plugin_loader'; -import { UnknownPanelCtrl } from 'app/plugins/panel/unknown/module'; - /** @ngInject */ function pluginDirectiveLoader($compile, datasourceSrv, $rootScope, $q, $http, $templateCache, $timeout) { function getTemplate(component) { @@ -69,7 +67,7 @@ function pluginDirectiveLoader($compile, datasourceSrv, $rootScope, $q, $http, $ }; const panelInfo = config.panels[scope.panel.type]; - let panelCtrlPromise = Promise.resolve(UnknownPanelCtrl); + let panelCtrlPromise = Promise.resolve(null); if (panelInfo) { panelCtrlPromise = importPluginModule(panelInfo.module).then(panelModule => { return panelModule.PanelCtrl; diff --git a/public/app/plugins/panel/unknown/module.html b/public/app/plugins/panel/unknown/module.html deleted file mode 100644 index 02c4dc97fc1..00000000000 --- a/public/app/plugins/panel/unknown/module.html +++ /dev/null @@ -1,5 +0,0 @@ -
- Unknown panel type: {{ctrl.panel.type}} -
- - diff --git a/public/app/plugins/panel/unknown/module.ts b/public/app/plugins/panel/unknown/module.ts deleted file mode 100644 index d7229913bc5..00000000000 --- a/public/app/plugins/panel/unknown/module.ts +++ /dev/null @@ -1,10 +0,0 @@ -import { PanelCtrl } from 'app/features/panel/panel_ctrl'; - -export class UnknownPanelCtrl extends PanelCtrl { - static templateUrl = 'public/app/plugins/panel/unknown/module.html'; - - /** @ngInject */ - constructor($scope, $injector) { - super($scope, $injector); - } -} diff --git a/public/app/types/plugins.ts b/public/app/types/plugins.ts index 109ca9c66f2..3875305ea9d 100644 --- a/public/app/types/plugins.ts +++ b/public/app/types/plugins.ts @@ -18,7 +18,6 @@ export interface PluginExports { export interface PanelPlugin { id: string; name: string; - meta: PluginMeta; hideFromList?: boolean; module: string; baseUrl: string;