From 993a2dacccc87171d2430470e89c32b0e68e439e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torkel=20=C3=96degaard?= Date: Thu, 10 Apr 2014 12:44:19 +0200 Subject: [PATCH] fixed failing unit test, added 2 more for setTime & auto refresh behavior --- src/test/mocks/dashboard-mock.js | 3 ++- src/test/specs/filterSrv-specs.js | 21 ++++++++++++++++++++- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/src/test/mocks/dashboard-mock.js b/src/test/mocks/dashboard-mock.js index 86317771639..ecc851e9de8 100644 --- a/src/test/mocks/dashboard-mock.js +++ b/src/test/mocks/dashboard-mock.js @@ -6,6 +6,7 @@ define([], create: function() { return { refresh: function() {}, + set_interval: function(value) { this.current.refresh = value; }, current: { title: "", @@ -33,7 +34,7 @@ define([], load_local: false, hide: false }, - refresh: false + refresh: true } }; } diff --git a/src/test/specs/filterSrv-specs.js b/src/test/specs/filterSrv-specs.js index 9dea9c1d5fc..1719827077f 100644 --- a/src/test/specs/filterSrv-specs.js +++ b/src/test/specs/filterSrv-specs.js @@ -7,10 +7,12 @@ define([ describe('filterSrv', function() { var _filterSrv; + var _dashboard; beforeEach(module('kibana.services')); beforeEach(module(function($provide){ - $provide.value('dashboard', dashboardMock.create()); + _dashboard = dashboardMock.create(); + $provide.value('dashboard', _dashboard); })); beforeEach(inject(function(filterSrv) { @@ -56,6 +58,23 @@ define([ }); }); + describe('setTime', function() { + it('should return disable refresh for absolute times', function() { + _dashboard.current.refresh = true; + + _filterSrv.setTime({from: '2011-01-01', to: '2015-01-01' }); + expect(_dashboard.current.refresh).to.be(false); + }); + + it('should restore refresh after relative time range is set', function() { + _dashboard.current.refresh = true; + _filterSrv.setTime({from: '2011-01-01', to: '2015-01-01' }); + expect(_dashboard.current.refresh).to.be(false); + _filterSrv.setTime({from: '2011-01-01', to: 'now' }); + expect(_dashboard.current.refresh).to.be(true); + }); + }); + }); });