IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Stars: fix stars api so it returns uids (#98637)

Browse Source
This commit is contained in:
Ryan McKinley 2025-01-07 23:39:25 +03:00 committed by GitHub
parent d436723745
commit 9b1ecaedda
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
pkg/services/star/api/api.go
View File

@ -52,13 +52,8 @@ func (api *API) getDashboardHelper(ctx context.Context, orgID int64, id int64, u
}
func (api *API) GetStars(c *contextmodel.ReqContext) response.Response {
userID, err := identity.UserIdentifier(c.SignedInUser.GetID())
if err != nil {
return response.Error(http.StatusBadRequest, "Only users and service accounts get starred dashboards", nil)
}
query := star.GetUserStarsQuery{
UserID: userID,
UserID: c.SignedInUser.UserID,
}
iuserstars, err := api.starService.GetByUser(c.Req.Context(), &query)
@ -67,20 +62,8 @@ func (api *API) GetStars(c *contextmodel.ReqContext) response.Response {
}
uids := []string{}
if len(iuserstars.UserStars) > 0 {
var uids []string
for uid := range iuserstars.UserStars {
uids = append(uids, uid)
}
starredDashboards, err := api.dashboardService.GetDashboards(c.Req.Context(), &dashboards.GetDashboardsQuery{DashboardUIDs: uids, OrgID: c.SignedInUser.GetOrgID()})
if err != nil {
return response.ErrOrFallback(http.StatusInternalServerError, "Failed to fetch dashboards", err)
}
uids = make([]string, len(starredDashboards))
for i, dash := range starredDashboards {
uids[i] = dash.UID
}
for uid := range iuserstars.UserStars {
uids = append(uids, uid)
}
return response.JSON(http.StatusOK, uids)