From 9d66b18b9c0099fe73521ba0918ee11a9443be37 Mon Sep 17 00:00:00 2001 From: Carl Bergquist Date: Tue, 7 Feb 2023 10:04:20 +0100 Subject: [PATCH] Instrumentation: removes option to return uname as header (#62929) Signed-off-by: bergquist --- .../setup-grafana/configure-grafana/feature-toggles/index.md | 1 - packages/grafana-data/src/types/featureToggles.gen.ts | 1 - pkg/services/contexthandler/contexthandler.go | 5 ----- pkg/services/featuremgmt/registry.go | 5 ----- pkg/services/featuremgmt/toggles_gen.go | 4 ---- 5 files changed, 16 deletions(-) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index 361bd8e3ccd..fa0ec65d364 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -56,7 +56,6 @@ Alpha features might be changed or removed without prior notice. | Feature toggle name | Description | | ---------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| `returnUnameHeader` | Return user login as header for authenticated requests | | `alertingBigTransactions` | Use big transactions for alerting database writes | | `dashboardPreviews` | Create and show thumbnails for dashboard search results | | `live-pipeline` | Enable a generic live processing pipeline | diff --git a/packages/grafana-data/src/types/featureToggles.gen.ts b/packages/grafana-data/src/types/featureToggles.gen.ts index 605a18a177b..c78e77384e6 100644 --- a/packages/grafana-data/src/types/featureToggles.gen.ts +++ b/packages/grafana-data/src/types/featureToggles.gen.ts @@ -16,7 +16,6 @@ export interface FeatureToggles { [name: string]: boolean | undefined; // support any string value - returnUnameHeader?: boolean; alertingBigTransactions?: boolean; trimDefaults?: boolean; disableEnvelopeEncryption?: boolean; diff --git a/pkg/services/contexthandler/contexthandler.go b/pkg/services/contexthandler/contexthandler.go index b06ee180127..e7f93205193 100644 --- a/pkg/services/contexthandler/contexthandler.go +++ b/pkg/services/contexthandler/contexthandler.go @@ -214,11 +214,6 @@ func (h *ContextHandler) Middleware(next http.Handler) http.Handler { } } - // this can be used by proxies to identify certain users - if h.features.IsEnabled(featuremgmt.FlagReturnUnameHeader) { - w.Header().Add("grafana-uname", reqContext.Login) - } - next.ServeHTTP(w, r) }) } diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index f4103b5b7a9..b6953048c43 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -9,11 +9,6 @@ package featuremgmt var ( // Register each toggle here standardFeatureFlags = []FeatureFlag{ - { - Name: "returnUnameHeader", - Description: "Return user login as header for authenticated requests", - State: FeatureStateAlpha, - }, { Name: "alertingBigTransactions", Description: "Use big transactions for alerting database writes", diff --git a/pkg/services/featuremgmt/toggles_gen.go b/pkg/services/featuremgmt/toggles_gen.go index f27f9a4d20b..3c31a064b44 100644 --- a/pkg/services/featuremgmt/toggles_gen.go +++ b/pkg/services/featuremgmt/toggles_gen.go @@ -7,10 +7,6 @@ package featuremgmt const ( - // FlagReturnUnameHeader - // Return user login as header for authenticated requests - FlagReturnUnameHeader = "returnUnameHeader" - // FlagAlertingBigTransactions // Use big transactions for alerting database writes FlagAlertingBigTransactions = "alertingBigTransactions"