From e2c958eb43e3d1373f8900edd112424d228d1e7e Mon Sep 17 00:00:00 2001 From: Jon Ferreira Date: Fri, 1 Feb 2019 14:16:27 -0500 Subject: [PATCH] Legend toggle should only trigger a re-render, not a refresh --- public/app/core/services/keybindingSrv.ts | 2 +- public/app/plugins/panel/graph/module.ts | 2 +- public/app/plugins/panel/graph/tab_legend.html | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/public/app/core/services/keybindingSrv.ts b/public/app/core/services/keybindingSrv.ts index 989746fd067..ed321c6a69e 100644 --- a/public/app/core/services/keybindingSrv.ts +++ b/public/app/core/services/keybindingSrv.ts @@ -249,7 +249,7 @@ export class KeybindingSrv { if (panelInfo.panel.legend) { const panelRef = dashboard.getPanelById(dashboard.meta.focusPanelId); panelRef.legend.show = !panelRef.legend.show; - panelRef.refresh(); + panelRef.render(); } } }); diff --git a/public/app/plugins/panel/graph/module.ts b/public/app/plugins/panel/graph/module.ts index f72b441b67b..68d982eab13 100644 --- a/public/app/plugins/panel/graph/module.ts +++ b/public/app/plugins/panel/graph/module.ts @@ -281,7 +281,7 @@ class GraphCtrl extends MetricsPanelCtrl { toggleLegend() { this.panel.legend.show = !this.panel.legend.show; - this.refresh(); + this.render(); } legendValuesOptionChanged() { diff --git a/public/app/plugins/panel/graph/tab_legend.html b/public/app/plugins/panel/graph/tab_legend.html index 82e1335dc10..b9c45447263 100644 --- a/public/app/plugins/panel/graph/tab_legend.html +++ b/public/app/plugins/panel/graph/tab_legend.html @@ -3,7 +3,7 @@
Options
+ checked="ctrl.panel.legend.show" on-change="ctrl.render()">