OAuth: Remove accessTokenExpirationCheck feature toggle (#79455)

* Remove accessTokenExpirationCheck from code and align docs

* Apply suggestions from code review

* lint

---------

Co-authored-by: lwandz13 <126723338+lwandz13@users.noreply.github.com>

pkg/services/authn/authnimpl/service.go

@@ -158,11 +158,7 @@ func ProvideService(
 	s.RegisterPostAuthHook(userSyncService.EnableUserHook, 20)
 	s.RegisterPostAuthHook(orgUserSyncService.SyncOrgRolesHook, 30)
 	s.RegisterPostAuthHook(userSyncService.SyncLastSeenHook, 120)
-
-	if features.IsEnabledGlobally(featuremgmt.FlagAccessTokenExpirationCheck) {
-		s.RegisterPostAuthHook(sync.ProvideOAuthTokenSync(oauthTokenService, sessionService, socialService).SyncOauthTokenHook, 60)
-	}
-
+	s.RegisterPostAuthHook(sync.ProvideOAuthTokenSync(oauthTokenService, sessionService, socialService).SyncOauthTokenHook, 60)
 	s.RegisterPostAuthHook(userSyncService.FetchSyncedUserHook, 100)
 	s.RegisterPostAuthHook(sync.ProvidePermissionsSync(accessControlService).SyncPermissionsHook, 110)
 

pkg/services/featuremgmt/registry.go

@@ -306,14 +306,6 @@ var (
 			AllowSelfServe: truePtr,
 			Created:        time.Date(2023, time.July, 24, 12, 0, 0, 0, time.UTC),
 		},
-		{
-			Name:           "accessTokenExpirationCheck",
-			Description:    "Enable OAuth access_token expiration check and token refresh using the refresh_token",
-			Stage:          FeatureStageGeneralAvailability,
-			Owner:          identityAccessTeam,
-			AllowSelfServe: falsePtr,
-			Created:        time.Date(2022, time.November, 14, 12, 0, 0, 0, time.UTC),
-		},
 		{
 			Name:              "emptyDashboardPage",
 			Description:       "Enable the redesigned user interface of a dashboard page that includes no panels",

pkg/services/featuremgmt/toggles_gen.csv

@@ -34,7 +34,6 @@ mysqlAnsiQuotes,experimental,@grafana/backend-platform,2022-10-12,false,false,fa
 accessControlOnCall,preview,@grafana/identity-access-team,2022-10-19,false,false,false,false
 nestedFolders,preview,@grafana/backend-platform,2022-10-22,false,false,false,false
 nestedFolderPicker,GA,@grafana/grafana-frontend-platform,2023-07-24,false,false,false,true
-accessTokenExpirationCheck,GA,@grafana/identity-access-team,2022-11-14,false,false,false,false
 emptyDashboardPage,GA,@grafana/dashboards-squad,2023-03-28,false,false,false,true
 disablePrometheusExemplarSampling,GA,@grafana/observability-metrics,2022-12-19,false,false,false,false
 alertingBacktesting,experimental,@grafana/alerting-squad,2022-10-20,false,false,false,false

pkg/services/featuremgmt/toggles_gen.go

@@ -147,10 +147,6 @@ const (
 	// Enables the new folder picker to work with nested folders. Requires the nestedFolders feature toggle
 	FlagNestedFolderPicker = "nestedFolderPicker"
 
-	// FlagAccessTokenExpirationCheck
-	// Enable OAuth access_token expiration check and token refresh using the refresh_token
-	FlagAccessTokenExpirationCheck = "accessTokenExpirationCheck"
-
 	// FlagEmptyDashboardPage
 	// Enable the redesigned user interface of a dashboard page that includes no panels
 	FlagEmptyDashboardPage = "emptyDashboardPage"