IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

preprocess lines reefactor

Browse Source
This commit is contained in:
Ivana 2021-02-26 12:48:56 +01:00
parent b985631df6
commit 9e9c034269
1 changed files with 7 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
public/app/plugins/datasource/loki/components/LokiOptionFields.tsx
View File

@ -25,8 +25,8 @@ const queryTypeOptions = [
export function LokiOptionFields(props: LokiOptionFieldsProps) { export function LokiOptionFields(props: LokiOptionFieldsProps) {
const { lineLimitValue, queryType, query, onRunQuery, runOnBlur, onChange } = props; const { lineLimitValue, queryType, query, onRunQuery, runOnBlur, onChange } = props;
function onChangeQueryLimit(value: string) { function onChangeQueryLimit(maxLines: number) {
const nextQuery = { ...query, maxLines: preprocessMaxLines(value) }; const nextQuery = { ...query, maxLines };
onChange(nextQuery); onChange(nextQuery);
} }
@ -40,23 +40,12 @@ export function LokiOptionFields(props: LokiOptionFieldsProps) {
onChange(nextQuery); onChange(nextQuery);
} }
function preprocessMaxLines(value: string): number {
if (value.length === 0) {
// empty input - falls back to dataSource.maxLines limit
return NaN;
} else if (value.length > 0 && (isNaN(+value) || +value < 0)) {
// input with at least 1 character and that is either incorrect (value in the input field is not a number) or negative
// falls back to the limit of 0 lines
return 0;
} else {
// default case - correct input
return +value;
}
}
function onMaxLinesChange(e: React.SyntheticEvent<HTMLInputElement>) { function onMaxLinesChange(e: React.SyntheticEvent<HTMLInputElement>) {
if (query.maxLines !== preprocessMaxLines(e.currentTarget.value)) { //If value is lower than 0, or if it can't be converted into number, we want to return 0
onChangeQueryLimit(e.currentTarget.value); const limit = Math.max(Number(e.currentTarget.value), 0);
//Run change only if limit changes
if (query.maxLines !== limit) {
onChangeQueryLimit(limit);
} }
} }