From a138ce668df0daac4840d37f4caac32dbaf3d813 Mon Sep 17 00:00:00 2001 From: Josh Hunt Date: Wed, 24 Jan 2024 17:24:24 +0000 Subject: [PATCH] I18n: Remove unneeded i18n:compile script (#81184) --- .drone.yml | 4 +--- package.json | 5 ++--- scripts/drone/steps/lib.star | 1 - 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/.drone.yml b/.drone.yml index 737398cc9b3..c10598c368a 100644 --- a/.drone.yml +++ b/.drone.yml @@ -248,7 +248,6 @@ steps: \"\nTranslation extraction has not been committed. Please run 'yarn i18n:extract', commit the changes and push again.\"\n exit 1\n fi\n \ " - - yarn run i18n:compile depends_on: - yarn-install failure: ignore @@ -1562,7 +1561,6 @@ steps: \"\nTranslation extraction has not been committed. Please run 'yarn i18n:extract', commit the changes and push again.\"\n exit 1\n fi\n \ " - - yarn run i18n:compile depends_on: - yarn-install failure: ignore @@ -4779,6 +4777,6 @@ kind: secret name: gcr_credentials --- kind: signature -hmac: 51ad95c27b1414d9e4acd0b920a3e9ceab5ccb2ef8df60fc43eb90c70cdf34d5 +hmac: 42c4eb79bab004d2916c7ab27b58e654300d2683345ea959bc052d1b3f107cd7 ... diff --git a/package.json b/package.json index 6ec0a01fe56..fed28d460fd 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,7 @@ "version": "10.4.0-pre", "repository": "github:grafana/grafana", "scripts": { - "prebuild": "yarn i18n:compile && yarn plugin:build", + "prebuild": "yarn plugin:build", "build": "yarn prebuild & NODE_ENV=production webpack --progress --config scripts/webpack/webpack.prod.js", "build:nominify": "yarn run build --env noMinify=1", "dev": "yarn prebuild & NODE_ENV=dev webpack --progress --color --config scripts/webpack/webpack.dev.js", @@ -24,7 +24,7 @@ "lint": "yarn run lint:ts && yarn run lint:sass", "lint:ts": "eslint . --ext .js,.tsx,.ts --cache", "lint:sass": "yarn stylelint '{public/sass,packages}/**/*.scss' --cache", - "test:ci": "yarn i18n:compile && mkdir -p reports/junit && JEST_JUNIT_OUTPUT_DIR=reports/junit jest --ci --reporters=default --reporters=jest-junit -w ${TEST_MAX_WORKERS:-100%}", + "test:ci": "mkdir -p reports/junit && JEST_JUNIT_OUTPUT_DIR=reports/junit jest --ci --reporters=default --reporters=jest-junit -w ${TEST_MAX_WORKERS:-100%}", "lint:fix": "yarn lint:ts --fix", "packages:build": "lerna run build --ignore '@grafana-plugins/*'", "packages:clean": "rimraf ./npm-artifacts && lerna run clean --parallel", @@ -48,7 +48,6 @@ "ci:test-frontend": "yarn run test:ci", "i18n:clean": "rimraf public/locales/en-US/grafana.json", "i18n:extract": "yarn run i18next -c public/locales/i18next-parser.config.js 'public/**/*.{tsx,ts}' 'packages/grafana-ui/**/*.{tsx,ts}' && yarn i18n:pseudo", - "i18n:compile": "echo 'no i18n compile yet, all good'", "i18n:pseudo": "node ./public/locales/pseudo.js", "i18n:stats": "node ./scripts/cli/reportI18nStats.mjs", "betterer": "betterer", diff --git a/scripts/drone/steps/lib.star b/scripts/drone/steps/lib.star index da3314774b0..091380d3aee 100644 --- a/scripts/drone/steps/lib.star +++ b/scripts/drone/steps/lib.star @@ -598,7 +598,6 @@ def verify_i18n_step(): exit 1 fi '''.format(uncommited_error_message), - "yarn run i18n:compile", ], }