IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Playlists: Save button now correctly creates a new playlist (#50381)

Browse Source 
* Add type="submit" to PlaylistForm submit button

* fix linting errors
This commit is contained in:
Ashley Harrison 2022-06-08 10:39:36 +01:00 committed by GitHub
parent 6e3d58d779
commit a1cf709ad2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
public/app/features/playlist/PlaylistForm.test.tsx
View File

@ -1,5 +1,5 @@
import { within } from '@testing-library/dom';
import { fireEvent, render, screen, waitFor } from '@testing-library/react';
import { render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import React from 'react';
@ -133,8 +133,8 @@ describe('PlaylistForm', () => {
it('then the correct item should be submitted', async () => {
const { onSubmitMock } = getTestContext(playlist);
fireEvent.submit(screen.getByRole('button', { name: /save/i }));
await waitFor(() => expect(onSubmitMock).toHaveBeenCalledTimes(1));
await userEvent.click(screen.getByRole('button', { name: /save/i }));
expect(onSubmitMock).toHaveBeenCalledTimes(1);
expect(onSubmitMock).toHaveBeenCalledWith(playlist);
});
@ -142,8 +142,8 @@ describe('PlaylistForm', () => {
it('then an alert should appear and nothing should be submitted', async () => {
const { onSubmitMock } = getTestContext({ ...playlist, name: undefined });
fireEvent.submit(screen.getByRole('button', { name: /save/i }));
expect(await screen.findAllByRole('alert')).toHaveLength(1);
await userEvent.click(screen.getByRole('button', { name: /save/i }));
expect(screen.getAllByRole('alert')).toHaveLength(1);
expect(onSubmitMock).not.toHaveBeenCalled();
});
});
@ -153,8 +153,8 @@ describe('PlaylistForm', () => {
const { onSubmitMock } = getTestContext(playlist);
await userEvent.clear(screen.getByRole('textbox', { name: /playlist interval/i }));
fireEvent.submit(screen.getByRole('button', { name: /save/i }));
expect(await screen.findAllByRole('alert')).toHaveLength(1);
await userEvent.click(screen.getByRole('button', { name: /save/i }));
expect(screen.getAllByRole('alert')).toHaveLength(1);
expect(onSubmitMock).not.toHaveBeenCalled();
});
});

2
public/app/features/playlist/PlaylistForm.tsx
View File

@ -70,7 +70,7 @@ export const PlaylistForm: FC<PlaylistFormProps> = ({ onSubmit, playlist }) => {
</div>
<HorizontalGroup>
<Button variant="primary" disabled={isDisabled}>
<Button type="submit" variant="primary" disabled={isDisabled}>
Save
</Button>
<LinkButton variant="secondary" href={`${config.appSubUrl}/playlists`}>