diff --git a/packages/jaeger-ui-components/src/TraceTimelineViewer/ListView/index.tsx b/packages/jaeger-ui-components/src/TraceTimelineViewer/ListView/index.tsx index 57bd8f51c92..e7587f0a563 100644 --- a/packages/jaeger-ui-components/src/TraceTimelineViewer/ListView/index.tsx +++ b/packages/jaeger-ui-components/src/TraceTimelineViewer/ListView/index.tsx @@ -215,10 +215,20 @@ export default class ListView extends React.Component { } } - componentDidUpdate() { + componentDidUpdate(prevProps: TListViewProps) { if (this._itemHolderElm) { this._scanItemHeights(); } + // When windowScroller is set to false, we can continue to handle scrollElement + if (this.props.windowScroller) { + return; + } + // check if the scrollElement changes and update its scroll listener + if (prevProps.scrollElement !== this.props.scrollElement) { + prevProps.scrollElement?.removeEventListener('scroll', this._onScroll); + this._wrapperElm = this.props.scrollElement; + this._wrapperElm?.addEventListener('scroll', this._onScroll); + } } componentWillUnmount() {