IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

AzureMonitor: Check to see if response is nil to prevent panic (#72705)

Browse Source 
* check to see if response is nil to prevent panic

* make function more go

* logging error and moving on

* lint
This commit is contained in:
Andrew Hackmann
2023-08-03 16:48:56 -05:00
committed by GitHub
parent e9c526b40c
commit a31d05980c
1 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
pkg/tsdb/azuremonitor/metrics/azuremonitor-datasource.go
View File

@@ -245,10 +245,10 @@ func getParams(azJSONModel *dataquery.AzureMetricQuery, query backend.DataQuery)
return params, nil return params, nil
} }
func (e *AzureMonitorDatasource) retrieveSubscriptionDetails(cli *http.Client, ctx context.Context, logger log.Logger, tracer tracing.Tracer, subscriptionId string, baseUrl string, dsId int64, orgId int64) string { func (e *AzureMonitorDatasource) retrieveSubscriptionDetails(cli *http.Client, ctx context.Context, logger log.Logger, tracer tracing.Tracer, subscriptionId string, baseUrl string, dsId int64, orgId int64) (string, error) {
req, err := e.createRequest(ctx, logger, fmt.Sprintf("%s/subscriptions/%s", baseUrl, subscriptionId)) req, err := e.createRequest(ctx, logger, fmt.Sprintf("%s/subscriptions/%s", baseUrl, subscriptionId))
if err != nil { if err != nil {
logger.Error("failed to retrieve subscription details for subscription %s: %s", subscriptionId, err) return "", fmt.Errorf("failed to retrieve subscription details for subscription %s: %s", subscriptionId, err)
} }
values := req.URL.Query() values := req.URL.Query()
values.Add("api-version", "2022-12-01") values.Add("api-version", "2022-12-01")
@@ -264,30 +264,30 @@ func (e *AzureMonitorDatasource) retrieveSubscriptionDetails(cli *http.Client, c
logger.Debug("AzureMonitor", "Subscription Details Req") logger.Debug("AzureMonitor", "Subscription Details Req")
res, err := cli.Do(req) res, err := cli.Do(req)
if err != nil { if err != nil {
logger.Warn("failed to request subscription details: %s", err) return "", fmt.Errorf("failed to request subscription details: %s", err)
} }
defer func() { defer func() {
if err := res.Body.Close(); err != nil { if err := res.Body.Close(); err != nil {
logger.Warn("Failed to close response body", "err", err) logger.Warn("failed to close response body", "err", err)
} }
}() }()
body, err := io.ReadAll(res.Body) body, err := io.ReadAll(res.Body)
if err != nil { if err != nil {
logger.Warn("failed to read response body: %s", err) return "", fmt.Errorf("failed to read response body: %s", err)
} }
if res.StatusCode/100 != 2 { if res.StatusCode/100 != 2 {
logger.Warn("request failed, status: %s, error: %s", res.Status, string(body)) return "", fmt.Errorf("request failed, status: %s, error: %s", res.Status, string(body))
} }
var data types.SubscriptionsResponse var data types.SubscriptionsResponse
err = json.Unmarshal(body, &data) err = json.Unmarshal(body, &data)
if err != nil { if err != nil {
logger.Warn("Failed to unmarshal subscription detail response", "error", err, "status", res.Status, "body", string(body)) return "", fmt.Errorf("failed to unmarshal subscription detail response. error: %s, status: %s, body: %s", err, res.Status, string(body))
} }
return data.DisplayName return data.DisplayName, nil
} }
func (e *AzureMonitorDatasource) executeQuery(ctx context.Context, logger log.Logger, query *types.AzureMonitorQuery, dsInfo types.DatasourceInfo, cli *http.Client, func (e *AzureMonitorDatasource) executeQuery(ctx context.Context, logger log.Logger, query *types.AzureMonitorQuery, dsInfo types.DatasourceInfo, cli *http.Client,
@@ -326,7 +326,7 @@ func (e *AzureMonitorDatasource) executeQuery(ctx context.Context, logger log.Lo
} }
defer func() { defer func() {
if err := res.Body.Close(); err != nil { if err := res.Body.Close(); err != nil {
logger.Warn("Failed to close response body", "err", err) logger.Warn("failed to close response body", "err", err)
} }
}() }()
@@ -342,7 +342,10 @@ func (e *AzureMonitorDatasource) executeQuery(ctx context.Context, logger log.Lo
return dataResponse return dataResponse
} }
subscription := e.retrieveSubscriptionDetails(cli, ctx, logger, tracer, query.Subscription, dsInfo.Routes["Azure Monitor"].URL, dsInfo.DatasourceID, dsInfo.OrgID) subscription, err := e.retrieveSubscriptionDetails(cli, ctx, logger, tracer, query.Subscription, dsInfo.Routes["Azure Monitor"].URL, dsInfo.DatasourceID, dsInfo.OrgID)
if err != nil {
logger.Warn(err.Error())
}
dataResponse.Frames, err = e.parseResponse(data, query, azurePortalUrl, subscription) dataResponse.Frames, err = e.parseResponse(data, query, azurePortalUrl, subscription)
if err != nil { if err != nil {
@@ -356,8 +359,8 @@ func (e *AzureMonitorDatasource) executeQuery(ctx context.Context, logger log.Lo
func (e *AzureMonitorDatasource) createRequest(ctx context.Context, logger log.Logger, url string) (*http.Request, error) { func (e *AzureMonitorDatasource) createRequest(ctx context.Context, logger log.Logger, url string) (*http.Request, error) {
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil) req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
if err != nil { if err != nil {
logger.Debug("Failed to create request", "error", err) logger.Debug("failed to create request", "error", err)
return nil, fmt.Errorf("%v: %w", "Failed to create request", err) return nil, fmt.Errorf("%v: %w", "failed to create request", err)
} }
req.Header.Set("Content-Type", "application/json") req.Header.Set("Content-Type", "application/json")
@@ -378,7 +381,7 @@ func (e *AzureMonitorDatasource) unmarshalResponse(logger log.Logger, res *http.
var data types.AzureMonitorResponse var data types.AzureMonitorResponse
err = json.Unmarshal(body, &data) err = json.Unmarshal(body, &data)
if err != nil { if err != nil {
logger.Debug("Failed to unmarshal AzureMonitor response", "error", err, "status", res.Status, "body", string(body)) logger.Debug("failed to unmarshal AzureMonitor response", "error", err, "status", res.Status, "body", string(body))
return types.AzureMonitorResponse{}, err return types.AzureMonitorResponse{}, err
} }