IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

api: Validate dashboards on save via coremodels, behind feature toggle (#48252)

Browse Source 
* Add coremodelValidation feature flag

* coremodels: use stubs when feature flag is off

* api: validate dashboards on save

* Need pointer receiver for FeatureManager

* Update dashboard Go model

* Align doc comments

* Include CoremodelRegistry in test

* Wedge coremodel in on all test cases, ugh

* Ugh fix comment again

* Update pkg/framework/coremodel/staticregistry/provide.go

Co-authored-by: Artur Wierzbicki <wierzbicki.artur.94@gmail.com>

* Update Thema (and its deps) for better errs

* omg whitespace

Co-authored-by: Artur Wierzbicki <wierzbicki.artur.94@gmail.com>
This commit is contained in:
sam boyer
2022-05-21 20:44:12 -04:00
committed by GitHub
parent 03fe1435a0
commit a3402641d6
11 changed files with 111 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/services/featuremgmt/registry.go
View File

@@ -243,5 +243,11 @@ var (
Description: "Enable streaming JSON parser for Prometheus datasource",
State: FeatureStateAlpha,
},
{
Name: "validateDashboardsOnSave",
Description: "Validate dashboard JSON POSTed to api/dashboards/db",
State: FeatureStateAlpha,
RequiresRestart: true,
},
}
)

4
pkg/services/featuremgmt/toggles_gen.go
View File

@@ -178,4 +178,8 @@ const (
// FlagPrometheusStreamingJSONParser
// Enable streaming JSON parser for Prometheus datasource
FlagPrometheusStreamingJSONParser = "prometheusStreamingJSONParser"
// FlagValidateDashboardsOnSave
// Validate dashboard JSON POSTed to api/dashboards/db
FlagValidateDashboardsOnSave = "validateDashboardsOnSave"
)