IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

NestedFolders: API improvements for NestedFolderPicker (#72093)

Browse Source 
* NestedFolders: Prepare nested folder picker for more usage

* fix betterer results

* Update usage of NestedFolderPicker

* fix tests

* fix betterer
This commit is contained in:
Josh Hunt
2023-07-21 14:40:39 +00:00
committed by GitHub
parent cfa1a2c55f
commit a5016c9e88
7 changed files with 50 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
public/app/core/components/NestedFolderPicker/NestedFolderPicker.test.tsx
View File

@@ -109,10 +109,7 @@ describe('NestedFolderPicker', () => {
await screen.findByLabelText(folderA.item.title);
await userEvent.click(screen.getByLabelText(folderA.item.title));
expect(mockOnChange).toHaveBeenCalledWith({
uid: folderA.item.uid,
title: folderA.item.title,
});
expect(mockOnChange).toHaveBeenCalledWith(folderA.item.uid, folderA.item.title);
});
it('can select a folder from the picker with the keyboard', async () => {
@@ -122,10 +119,7 @@ describe('NestedFolderPicker', () => {
await userEvent.click(button);
await userEvent.keyboard('{ArrowDown}{ArrowDown}{Enter}');
expect(mockOnChange).toHaveBeenCalledWith({
uid: folderA.item.uid,
title: folderA.item.title,
});
expect(mockOnChange).toHaveBeenCalledWith(folderA.item.uid, folderA.item.title);
});
it('can expand and collapse a folder to show its children', async () => {
@@ -156,10 +150,7 @@ describe('NestedFolderPicker', () => {
// Select the first child
await userEvent.click(screen.getByLabelText(folderA_folderA.item.title));
expect(mockOnChange).toHaveBeenCalledWith({
uid: folderA_folderA.item.uid,
title: folderA_folderA.item.title,
});
expect(mockOnChange).toHaveBeenCalledWith(folderA_folderA.item.uid, folderA_folderA.item.title);
});
it('can expand and collapse a folder to show its children with the keyboard', async () => {
@@ -185,9 +176,6 @@ describe('NestedFolderPicker', () => {
// Select the first child
await userEvent.keyboard('{ArrowDown}{Enter}');
expect(mockOnChange).toHaveBeenCalledWith({
uid: folderA_folderA.item.uid,
title: folderA_folderA.item.title,
});
expect(mockOnChange).toHaveBeenCalledWith(folderA_folderA.item.uid, folderA_folderA.item.title);
});
});