From a5133d61b5cc50841b03415dbbb40fa62515b944 Mon Sep 17 00:00:00 2001
From: Yuri Tseretyan <yuriy.tseretyan@grafana.com>
Date: Wed, 8 Mar 2023 11:03:06 -0500
Subject: [PATCH] Code: Ownership for alerting feature toggles (#64426)

* add alerting squad as an owner of some feature flags

* remove flags from owneless

---------

Co-authored-by: Artur Wierzbicki <artur.wierzbicki@grafana.com>
---
 pkg/services/featuremgmt/codeowners.go       | 1 +
 pkg/services/featuremgmt/registry.go         | 3 +++
 pkg/services/featuremgmt/toggles_gen_test.go | 3 ---
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/pkg/services/featuremgmt/codeowners.go b/pkg/services/featuremgmt/codeowners.go
index 84d3cc267f8..b53d08c58fc 100644
--- a/pkg/services/featuremgmt/codeowners.go
+++ b/pkg/services/featuremgmt/codeowners.go
@@ -17,4 +17,5 @@ const (
 	grafanaAuthnzSquad                          codeowner = "@grafana/grafana-authnz-team"
 	grafanaObservabilityLogsSquad               codeowner = "@grafana/observability-logs"
 	grafanaObservabilityTracesAndProfilingSquad codeowner = "@grafana/observability-traces-and-profiling"
+	grafanaAlertingSquad                        codeowner = "@grafana/alerting-squad"
 )
diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go
index b04b75c2360..293e107d81c 100644
--- a/pkg/services/featuremgmt/registry.go
+++ b/pkg/services/featuremgmt/registry.go
@@ -13,6 +13,7 @@ var (
 			Name:        "alertingBigTransactions",
 			Description: "Use big transactions for alerting database writes",
 			State:       FeatureStateAlpha,
+			Owner:       grafanaAlertingSquad,
 		},
 		{
 			Name:        "trimDefaults",
@@ -356,6 +357,7 @@ var (
 			Name:        "alertingBacktesting",
 			Description: "Rule backtesting API for alerting",
 			State:       FeatureStateAlpha,
+			Owner:       grafanaAlertingSquad,
 		},
 		{
 			Name:         "editPanelCSVDragAndDrop",
@@ -369,6 +371,7 @@ var (
 			Description:     "Stop maintaining state of alerts that are not firing",
 			State:           FeatureStateBeta,
 			RequiresRestart: false,
+			Owner:           grafanaAlertingSquad,
 		},
 		{
 
diff --git a/pkg/services/featuremgmt/toggles_gen_test.go b/pkg/services/featuremgmt/toggles_gen_test.go
index 6bbba1461af..28e5b2cbfa2 100644
--- a/pkg/services/featuremgmt/toggles_gen_test.go
+++ b/pkg/services/featuremgmt/toggles_gen_test.go
@@ -42,7 +42,6 @@ func TestFeatureToggleFiles(t *testing.T) {
 	})
 
 	ownerlessFeatures := map[string]bool{
-		"alertingBigTransactions":           true,
 		"database_metrics":                  true,
 		"prometheusAzureOverrideAudience":   true,
 		"tracing":                           true,
@@ -59,8 +58,6 @@ func TestFeatureToggleFiles(t *testing.T) {
 		"datasourceOnboarding":              true,
 		"secureSocksDatasourceProxy":        true,
 		"disablePrometheusExemplarSampling": true,
-		"alertingBacktesting":               true,
-		"alertingNoNormalState":             true,
 		"individualCookiePreferences":       true,
 	}