IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

feat(inspector): fixed error handling, showing response body when data proxy returns text/html body

Browse Source
This commit is contained in:
Torkel Ödegaard 2016-08-16 22:31:26 +02:00
parent 58df60f670
commit a5f0f508ea
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
public/app/core/controllers/inspect_ctrl.js
View File

@ -7,7 +7,7 @@ define([
function (angular, _, $, coreModule) { function (angular, _, $, coreModule) {
'use strict'; 'use strict';
coreModule.default.controller('InspectCtrl', function($scope) { coreModule.default.controller('InspectCtrl', function($scope, $sanitize) {
var model = $scope.inspector; var model = $scope.inspector;
function getParametersFromQueryString(queryString) { function getParametersFromQueryString(queryString) {
@ -32,7 +32,11 @@ function (angular, _, $, coreModule) {
if (_.isString(model.error.data)) { if (_.isString(model.error.data)) {
$scope.response = $("<div>" + model.error.data + "</div>").text(); $scope.response = $("<div>" + model.error.data + "</div>").text();
} else if (model.error.data) { } else if (model.error.data) {
if (model.error.data.response) {
$scope.response = $sanitize(model.error.data.response);
} else {
$scope.response = angular.toJson(model.error.data, true); $scope.response = angular.toJson(model.error.data, true);
}
} else if (model.error.message) { } else if (model.error.message) {
$scope.message = model.error.message; $scope.message = model.error.message;
} }

3
public/app/core/services/backend_srv.ts
View File

@ -138,7 +138,8 @@ export class BackendSrv {
//populate error obj on Internal Error //populate error obj on Internal Error
if (_.isString(err.data) && err.status === 500) { if (_.isString(err.data) && err.status === 500) {
err.data = { err.data = {
error: err.statusText error: err.statusText,
response: err.data,
}; };
} }