From a8a8c9849d161cdca59361f012ab294a2fe62086 Mon Sep 17 00:00:00 2001
From: Joey <90795735+joey-grafana@users.noreply.github.com>
Date: Wed, 13 Sep 2023 14:23:17 +0100
Subject: [PATCH] Tempo: Metrics summary update sorting no values (#74818)

* Update sorting when there is no value

* Update test
---
 public/app/plugins/datasource/tempo/metricsSummary.test.ts | 2 ++
 public/app/plugins/datasource/tempo/metricsSummary.ts      | 5 +++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/public/app/plugins/datasource/tempo/metricsSummary.test.ts b/public/app/plugins/datasource/tempo/metricsSummary.test.ts
index b01c7d19bb1..47c5bab6bd8 100644
--- a/public/app/plugins/datasource/tempo/metricsSummary.test.ts
+++ b/public/app/plugins/datasource/tempo/metricsSummary.test.ts
@@ -66,6 +66,7 @@ describe('MetricsSummary', () => {
                       "url": "",
                     },
                   ],
+                  "noValue": "<no value>",
                 },
                 "name": "span.http.status_code",
                 "type": "string",
@@ -90,6 +91,7 @@ describe('MetricsSummary', () => {
                       "url": "",
                     },
                   ],
+                  "noValue": "<no value>",
                 },
                 "name": "temperature",
                 "type": "string",
diff --git a/public/app/plugins/datasource/tempo/metricsSummary.ts b/public/app/plugins/datasource/tempo/metricsSummary.ts
index 29402b2ef86..68898a8d840 100644
--- a/public/app/plugins/datasource/tempo/metricsSummary.ts
+++ b/public/app/plugins/datasource/tempo/metricsSummary.ts
@@ -101,7 +101,7 @@ export function createTableFrameFromMetricsSummaryQuery(
       field.values.push(trace[field.name]);
     }
   }
-  frame = sortDataFrame(frame, 0, true);
+  frame = sortDataFrame(frame, 0);
 
   return [frame];
 }
@@ -158,6 +158,7 @@ export const getConfigQuery = (series: Series[], targetQuery: string) => {
 const getConfig = (series: Series, query: string, instanceSettings: DataSourceInstanceSettings) => {
   const commonConfig = {
     displayNameFromDS: series.key,
+    noValue: '<no value>',
     links: [
       {
         title: 'Query in explore',
@@ -183,7 +184,7 @@ const getConfig = (series: Series, query: string, instanceSettings: DataSourceIn
   return { ...commonConfig };
 };
 
-const NO_VALUE = '<no value>';
+const NO_VALUE = '';
 
 const getMetricValue = (series: Series) => {
   if (!series.value.type) {