IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Alerting: update state manager to return StateTransition instead of State (#58867)

Browse Source 
* improve test for stale states
* update state manager return StateTransition
* update scheduler to accept state transitions
This commit is contained in:
Yuri Tseretyan
2022-12-06 13:07:39 -05:00
committed by GitHub
parent a85adeed96
commit abb49d96b5
6 changed files with 108 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/services/ngalert/state/manager.go
View File

@@ -167,7 +167,7 @@ func (st *Manager) ResetStateByRuleUID(ctx context.Context, ruleKey ngModels.Ale
// ProcessEvalResults updates the current states that belong to a rule with the evaluation results.
// if extraLabels is not empty, those labels will be added to every state. The extraLabels take precedence over rule labels and result labels
func (st *Manager) ProcessEvalResults(ctx context.Context, evaluatedAt time.Time, alertRule *ngModels.AlertRule, results eval.Results, extraLabels data.Labels) []*State {
func (st *Manager) ProcessEvalResults(ctx context.Context, evaluatedAt time.Time, alertRule *ngModels.AlertRule, results eval.Results, extraLabels data.Labels) []StateTransition {
logger := st.log.FromContext(ctx)
logger.Debug("State manager processing evaluation results", "resultCount", len(results))
var states []StateTransition
@@ -185,18 +185,7 @@ func (st *Manager) ProcessEvalResults(ctx context.Context, evaluatedAt time.Time
if st.historian != nil {
st.historian.RecordStatesAsync(ctx, alertRule, allChanges)
}
nextStates := make([]*State, 0, len(states))
for _, s := range states {
nextStates = append(nextStates, s.State)
}
// TODO refactor further. Do not filter because it will be filtered downstream
for _, s := range staleStates {
if s.PreviousState == eval.Alerting {
nextStates = append(nextStates, s.State)
}
}
return nextStates
return allChanges
}
// Set the current state based on evaluation results