IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Frontend Sandbox: Do not consider internal plugins as elegible (#96325)

Browse Source
This commit is contained in:
Esteban Beltran 2024-11-13 09:28:19 +01:00 committed by GitHub
parent f83f7332a1
commit acf57aa556
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
public/app/features/plugins/sandbox/sandbox_plugin_loader_registry.test.ts
View File

@ -7,6 +7,7 @@ import {
shouldLoadPluginInFrontendSandbox, shouldLoadPluginInFrontendSandbox,
setSandboxEnabledCheck, setSandboxEnabledCheck,
isPluginFrontendSandboxEnabled, isPluginFrontendSandboxEnabled,
isPluginFrontendSandboxEligible,
} from './sandbox_plugin_loader_registry'; } from './sandbox_plugin_loader_registry';
jest.mock('@grafana/runtime', () => ({ jest.mock('@grafana/runtime', () => ({
@ -89,4 +90,11 @@ describe('Sandbox eligibility checks', () => {
expect(customCheck).toHaveBeenCalledWith({ pluginId: 'test-plugin' }); expect(customCheck).toHaveBeenCalledWith({ pluginId: 'test-plugin' });
expect(result).toBe(false); expect(result).toBe(false);
}); });
test('isPluginFrontendSandboxEligible returns false for plugins with internal signature', async () => {
//@ts-expect-error We don't publicly export the internal signature
getPluginSettingsMock.mockResolvedValue({ ...fakePlugin, signature: 'internal' });
const result = await isPluginFrontendSandboxEligible({ pluginId: 'test-plugin' });
expect(result).toBe(false);
});
}); });

2
public/app/features/plugins/sandbox/sandbox_plugin_loader_registry.ts
View File

@ -64,7 +64,7 @@ export async function isPluginFrontendSandboxEligible({
try { try {
// don't run grafana-signed plugins in sandbox // don't run grafana-signed plugins in sandbox
const pluginMeta = await getPluginSettings(pluginId, { showErrorAlert: false }); const pluginMeta = await getPluginSettings(pluginId, { showErrorAlert: false });
if (pluginMeta.signatureType === PluginSignatureType.grafana) { if (pluginMeta.signatureType === PluginSignatureType.grafana || pluginMeta.signature === 'internal') {
return false; return false;
} }
} catch (e) { } catch (e) {