Chore: MEGA - Make Eslint Great Again 💅 (#26094)

* Fix lint error in types.ts

* Bump eslint and its deps to latest

* Add eslintignore and remove not needed eslintrcs

* Change webpack configs eslint config

* Update package.jsons and removed unused eslintrc files

* Chore yarn lint --fix 💅

* Add devenv to eslintignore

* Remove eslint disable comments for rules that are not used

* Remaining eslint fixes 💅

* Bump grafana/eslint-config 💥

* Modify package.json

No need for duplicate checks.

* Modify eslintignore to ignore data and dist folders

* Revert removing .eslintrc to make sure not to use certain packages

* Modify package.json to remove not needed command

* Use gitignore for ignoring paths

scripts/webpack/loaders/blobUrl.js

@@ -2,5 +2,7 @@ const loaderUtils = require('loader-utils');
 
 module.exports = function blobUrl(source) {
   const { type } = loaderUtils.getOptions(this) || {};
-  return `module.exports = URL.createObjectURL(new Blob([${JSON.stringify(source)}]${type ? `, { type: ${JSON.stringify(type)} }` : ''}));`;
+  return `module.exports = URL.createObjectURL(new Blob([${JSON.stringify(source)}]${
+    type ? `, { type: ${JSON.stringify(type)} }` : ''
+  }));`;
 };

scripts/webpack/loaders/compile.js

@@ -40,7 +40,7 @@ module.exports.pitch = function pitch(remainingRequest) {
     // https://github.com/webpack/webpack/blob/master/lib/WebpackOptionsApply.js
     new WebWorkerTemplatePlugin(outputOptions),
     new LoaderTargetPlugin('webworker'),
-    ...((this.target === 'web') || (this.target === 'webworker') ? [] : [new NodeTargetPlugin()]),
+    ...(this.target === 'web' || this.target === 'webworker' ? [] : [new NodeTargetPlugin()]),
 
     // https://github.com/webpack-contrib/worker-loader/issues/95#issuecomment-352856617
     ...(compilerOptions.externals ? [new ExternalsPlugin(compilerOptions.externals)] : []),
@@ -52,19 +52,29 @@ module.exports.pitch = function pitch(remainingRequest) {
 
   const subCache = `subcache ${__dirname} ${remainingRequest}`;
 
-  childCompiler.plugin('compilation', (compilation) => {
-    if (!compilation.cache) { return; }
-    if (!(subCache in compilation.cache)) { Object.assign(compilation.cache, { [subCache]: {} }); }
+  childCompiler.plugin('compilation', compilation => {
+    if (!compilation.cache) {
+      return;
+    }
+    if (!(subCache in compilation.cache)) {
+      Object.assign(compilation.cache, { [subCache]: {} });
+    }
     Object.assign(compilation, { cache: compilation.cache[subCache] });
   });
 
   const callback = this.async();
 
   childCompiler.runAsChild((error, entries, compilation) => {
-    if (error) { return callback(error); }
-    if (entries.length === 0) { return callback(null, null); }
+    if (error) {
+      return callback(error);
+    }
+    if (entries.length === 0) {
+      return callback(null, null);
+    }
     const mainFilename = entries[0].files[0];
-    if (emit === false) { delete currentCompilation.assets[mainFilename]; }
+    if (emit === false) {
+      delete currentCompilation.assets[mainFilename];
+    }
     callback(null, compilation.assets[mainFilename].source(), null, {
       [COMPILATION_METADATA]: entries[0].files,
     });
@@ -72,8 +82,12 @@ module.exports.pitch = function pitch(remainingRequest) {
 };
 
 function getOutputFilename(options, { target }) {
-  if (!options) { return { filename: `[hash].${target}.js`, options: undefined }; }
-  if (typeof options === 'string') { return { filename: options, options: undefined }; }
+  if (!options) {
+    return { filename: `[hash].${target}.js`, options: undefined };
+  }
+  if (typeof options === 'string') {
+    return { filename: options, options: undefined };
+  }
   if (typeof options === 'object') {
     return {
       filename: options.filename,

scripts/webpack/postcss.config.js

@@ -4,6 +4,6 @@ module.exports = () => {
       autoprefixer: {},
       'postcss-reporter': {},
       'postcss-browser-reporter': {},
-    }
+    },
   };
 };

scripts/webpack/sass.rule.js

@@ -12,7 +12,7 @@ module.exports = function(options) {
         options: {
           importLoaders: 2,
           url: options.preserveUrl,
-          sourceMap: options.sourceMap
+          sourceMap: options.sourceMap,
         },
       },
       {
@@ -25,7 +25,7 @@ module.exports = function(options) {
       {
         loader: 'sass-loader',
         options: {
-          sourceMap: options.sourceMap
+          sourceMap: options.sourceMap,
         },
       },
     ],

scripts/webpack/webpack.dev.js

@@ -89,15 +89,7 @@ module.exports = (env = {}) =>
         : new ForkTsCheckerWebpackPlugin({
             eslint: {
               enabled: true,
-              files: [
-                'public/app/**/*.{ts,tsx}',
-                // this can't be written like this packages/**/src/**/*.ts because it throws an error
-                'packages/grafana-ui/src/**/*.{ts,tsx}',
-                'packages/grafana-data/src/**/*.{ts,tsx}',
-                'packages/grafana-runtime/src/**/*.{ts,tsx}',
-                'packages/grafana-e2e-selectors/src/**/*.{ts,tsx}',
-                'packages/jaeger-ui-components/src/**/*.{ts,tsx}',
-              ],
+              files: ['public/app/**/*.{ts,tsx}', 'packages/*/src/**/*.{ts,tsx}'],
               options: {
                 cache: true,
               },

scripts/webpack/webpack.prod.js

@@ -89,15 +89,7 @@ module.exports = merge(common, {
     new ForkTsCheckerWebpackPlugin({
       eslint: {
         enabled: true,
-        files: [
-          'public/app/**/*.{ts,tsx}',
-          // this can't be written like this packages/**/src/**/*.ts because it throws an error
-          'packages/grafana-ui/src/**/*.{ts,tsx}',
-          'packages/grafana-data/src/**/*.{ts,tsx}',
-          'packages/grafana-runtime/src/**/*.{ts,tsx}',
-          'packages/grafana-e2e-selectors/src/**/*.{ts,tsx}',
-          'packages/jaeger-ui-components/src/**/*.{ts,tsx}',
-        ],
+        files: ['public/app/**/*.{ts,tsx}', 'packages/*/src/**/*.{ts,tsx}'],
       },
       typescript: {
         mode: 'write-references',