Precommit: Fixed precommit task issue (#18883)

This commit is contained in:
Torkel Ödegaard
2019-09-04 12:45:01 +02:00
committed by GitHub
parent cb4d30f852
commit b0237c6b7e

View File

@@ -11,15 +11,6 @@ const simpleGit = require('simple-git/promise')(process.cwd());
interface PrecommitOptions {} interface PrecommitOptions {}
const tasks = {
test: {
lint: {
ts: ['no-only-tests'],
go: ['no-focus-convey-tests'],
},
},
};
interface GitStatus { interface GitStatus {
files: GitFile[]; files: GitFile[];
} }
@@ -40,27 +31,26 @@ const precommitRunner: TaskRunner<PrecommitOptions> = async () => {
.filter(file => nodeVersionFiles.indexOf(file.path) !== -1) .filter(file => nodeVersionFiles.indexOf(file.path) !== -1)
.map(f => f.path); .map(f => f.path);
const taskPaths = []; const gruntTasks = [];
if (affectedNodeVersionFiles.length > 0) { if (affectedNodeVersionFiles.length > 0) {
await execTask(nodeVersionCheckerTask)({}); await execTask(nodeVersionCheckerTask)({});
} }
if (sassFiles.length > 0) { if (sassFiles.length > 0) {
taskPaths.push('lint.sass'); gruntTasks.push('sasslint');
} }
if (testFiles.length) { if (testFiles.length) {
taskPaths.push('test.lint.ts'); gruntTasks.push('no-only-tests');
} }
if (goTestFiles.length) { if (goTestFiles.length) {
taskPaths.push('test.lint.go'); gruntTasks.push('no-focus-convey-tests');
} }
const gruntTasks = flatten(taskPaths.map(path => get(tasks, path)));
if (gruntTasks.length > 0) { if (gruntTasks.length > 0) {
console.log(chalk.yellow(`Precommit checks: ${taskPaths.join(', ')}`)); console.log(chalk.yellow(`Precommit checks: ${gruntTasks.join(', ')}`));
const task = execa('grunt', gruntTasks); const task = execa('grunt', gruntTasks);
// @ts-ignore // @ts-ignore
const stream = task.stdout; const stream = task.stdout;