IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-14 01:23:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Enable and Fix flaky test in anonimpl service (#80896)

Browse Source 
* fix: flaky test

* set fixed time instead

* flaky
This commit is contained in:
Eric Leijonmarck 2024-01-23 12:27:26 +00:00 committed by GitHub
parent 5887f421b3
commit b43b2608b5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 82 additions and 87 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

169
pkg/services/anonymous/anonimpl/impl_test.go
View File

@ -178,92 +178,87 @@ func TestIntegrationAnonDeviceService_localCacheSafety(t *testing.T) {
assert.Equal(t, int64(0), stats["stats.anonymous.device.ui.count"].(int64))
}
// func TestIntegrationDeviceService_SearchDevice(t *testing.T) {
// t.Skip("Flaky test, @eleijonmarck will fix")
// testCases := []struct {
// name string
// insertDevices []*anonstore.Device
// searchQuery anonstore.SearchDeviceQuery
// expectedCount int
// expectedDevice *anonstore.Device
// }{
// {
// name: "two devices and limit set to 1",
// insertDevices: []*anonstore.Device{
// {
// DeviceID: "32mdo31deeqwes",
// ClientIP: "",
// UserAgent: "test",
// CreatedAt: time.Now().Add(-10 * time.Hour).UTC(),
// UpdatedAt: time.Now().UTC(),
// },
// {
// DeviceID: "32mdo31deeqwes2",
// ClientIP: "",
// UserAgent: "test2",
// CreatedAt: time.Now().Add(-10 * time.Hour).UTC(),
// UpdatedAt: time.Now().UTC(),
// },
// },
// searchQuery: anonstore.SearchDeviceQuery{
// Query: "",
// Page: 1,
// Limit: 1,
// },
// expectedCount: 1,
// },
// {
// name: "two devices and search for client ip 192.1",
// insertDevices: []*anonstore.Device{
// {
// DeviceID: "32mdo31deeqwes",
// ClientIP: "192.168.0.2:10",
// UserAgent: "",
// CreatedAt: time.Now().Add(-10 * time.Hour).UTC(),
// UpdatedAt: time.Now().UTC(),
// },
// {
// DeviceID: "32mdo31deeqwes2",
// ClientIP: "192.268.1.3:200",
// UserAgent: "",
// CreatedAt: time.Now().Add(-10 * time.Hour).UTC(),
// UpdatedAt: time.Now().UTC(),
// },
// },
// searchQuery: anonstore.SearchDeviceQuery{
// Query: "192.1",
// Page: 1,
// Limit: 50,
// },
// expectedCount: 1,
// expectedDevice: &anonstore.Device{
// DeviceID: "32mdo31deeqwes",
// ClientIP: "192.168.0.2:10",
// UserAgent: "",
// CreatedAt: time.Now().Add(-10 * time.Hour).UTC(),
// UpdatedAt: time.Now().UTC(),
// },
// },
// }
// store := db.InitTestDB(t)
// anonService := ProvideAnonymousDeviceService(&usagestats.UsageStatsMock{},
// &authntest.FakeService{}, store, setting.NewCfg(), orgtest.NewOrgServiceFake(), nil, actest.FakeAccessControl{}, &routing.RouteRegisterImpl{})
func TestIntegrationDeviceService_SearchDevice(t *testing.T) {
fixedTime := time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC) // Fixed timestamp for testing
// for _, tc := range testCases {
// t.Run(tc.name, func(t *testing.T) {
// for _, device := range tc.insertDevices {
// err := anonService.anonStore.CreateOrUpdateDevice(context.Background(), device)
// require.NoError(t, err)
// }
testCases := []struct {
name string
insertDevices []*anonstore.Device
searchQuery anonstore.SearchDeviceQuery
expectedCount int
expectedDevice *anonstore.Device
}{
{
name: "two devices and limit set to 1",
insertDevices: []*anonstore.Device{
{
DeviceID: "32mdo31deeqwes",
ClientIP: "",
UserAgent: "test",
},
{
DeviceID: "32mdo31deeqwes2",
ClientIP: "",
UserAgent: "test2",
},
},
searchQuery: anonstore.SearchDeviceQuery{
Query: "",
Page: 1,
Limit: 1,
},
expectedCount: 1,
},
{
name: "two devices and search for client ip 192.1",
insertDevices: []*anonstore.Device{
{
DeviceID: "32mdo31deeqwes",
ClientIP: "192.168.0.2:10",
UserAgent: "",
},
{
DeviceID: "32mdo31deeqwes2",
ClientIP: "192.268.1.3:200",
UserAgent: "",
},
},
searchQuery: anonstore.SearchDeviceQuery{
Query: "192.1",
Page: 1,
Limit: 50,
},
expectedCount: 1,
expectedDevice: &anonstore.Device{
DeviceID: "32mdo31deeqwes",
ClientIP: "192.168.0.2:10",
UserAgent: "",
},
},
}
store := db.InitTestDB(t)
cfg := setting.NewCfg()
cfg.AnonymousEnabled = true
anonService := ProvideAnonymousDeviceService(&usagestats.UsageStatsMock{}, &authntest.FakeService{}, store, cfg, orgtest.NewOrgServiceFake(), nil, actest.FakeAccessControl{}, &routing.RouteRegisterImpl{})
// devices, err := anonService.anonStore.SearchDevices(context.Background(), &tc.searchQuery)
// require.NoError(t, err)
// require.Len(t, devices.Devices, tc.expectedCount)
// if tc.expectedDevice != nil {
// device := devices.Devices[0]
// require.Equal(t, tc.expectedDevice.UserAgent, device.UserAgent)
// }
// })
// }
// }
//
for _, tc := range testCases {
err := store.Reset()
assert.NoError(t, err)
t.Run(tc.name, func(t *testing.T) {
for _, device := range tc.insertDevices {
device.CreatedAt = fixedTime.Add(-10 * time.Hour) // Use fixed time
device.UpdatedAt = fixedTime
err := anonService.anonStore.CreateOrUpdateDevice(context.Background(), device)
require.NoError(t, err)
}
devices, err := anonService.anonStore.SearchDevices(context.Background(), &tc.searchQuery)
require.NoError(t, err)
require.Len(t, devices.Devices, tc.expectedCount)
if tc.expectedDevice != nil {
device := devices.Devices[0]
require.Equal(t, tc.expectedDevice.UserAgent, device.UserAgent)
}
})
}
}