From b75276c64180cf2fc903650290b1db864797fe58 Mon Sep 17 00:00:00 2001 From: Leonor Oliveira <9090754+leonorfmartins@users.noreply.github.com> Date: Thu, 11 Jul 2024 12:50:20 +0100 Subject: [PATCH] Fix outcome metric (#90322) --- pkg/apiserver/rest/metrics.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/apiserver/rest/metrics.go b/pkg/apiserver/rest/metrics.go index 5e066daec50e..0b85e7268b6a 100644 --- a/pkg/apiserver/rest/metrics.go +++ b/pkg/apiserver/rest/metrics.go @@ -68,9 +68,9 @@ func (m *dualWriterMetrics) recordStorageDuration(isError bool, mode string, nam m.storage.WithLabelValues(strconv.FormatBool(isError), mode, name, method).Observe(duration) } -func (m *dualWriterMetrics) recordOutcome(mode string, name string, outcome bool, method string) { +func (m *dualWriterMetrics) recordOutcome(mode string, name string, areEqual bool, method string) { var observeValue float64 - if outcome { + if !areEqual { observeValue = 1 } m.outcome.WithLabelValues(mode, name, method).Observe(observeValue)