Tempo: Improve UX of the query editors status select (#82167)

Improve status UX
This commit is contained in:
Joey 2024-02-15 09:34:14 +00:00 committed by GitHub
parent a922ce86c8
commit b81c3ab9c1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 3 deletions

View File

@ -33,6 +33,8 @@ interface Props {
hideTag?: boolean; hideTag?: boolean;
hideValue?: boolean; hideValue?: boolean;
query: string; query: string;
isMulti?: boolean;
allowCustomValue?: boolean;
} }
const SearchField = ({ const SearchField = ({
filter, filter,
@ -45,6 +47,8 @@ const SearchField = ({
hideTag, hideTag,
hideValue, hideValue,
query, query,
isMulti = true,
allowCustomValue = true,
}: Props) => { }: Props) => {
const styles = useStyles2(getStyles); const styles = useStyles2(getStyles);
const scopedTag = useMemo(() => filterScopedTag(filter), [filter]); const scopedTag = useMemo(() => filterScopedTag(filter), [filter]);
@ -195,10 +199,10 @@ const SearchField = ({
} }
}} }}
placeholder="Select value" placeholder="Select value"
isClearable={false} isClearable={true}
aria-label={`select ${filter.id} value`} aria-label={`select ${filter.id} value`}
allowCustomValue={true} allowCustomValue={allowCustomValue}
isMulti isMulti={isMulti}
allowCreateWhileLoading allowCreateWhileLoading
/> />
)} )}

View File

@ -151,6 +151,8 @@ const TraceQLSearch = ({ datasource, query, onChange, onClearResults, app }: Pro
hideScope={true} hideScope={true}
hideTag={true} hideTag={true}
query={traceQlQuery} query={traceQlQuery}
isMulti={false}
allowCustomValue={false}
/> />
</InlineSearchField> </InlineSearchField>
<InlineSearchField <InlineSearchField