From b8d4d28f4a7b5068d162f9f2e6908d29adec5a19 Mon Sep 17 00:00:00 2001
From: Dominik Prokop <dominik.prokop@grafana.com>
Date: Tue, 12 Mar 2024 13:54:55 +0100
Subject: [PATCH] DashboardScene: Fix Get Help panel menu for lib panels
 (#84272)

---
 .../HelpWizard/SupportSnapshotService.ts      | 13 +++++-----
 .../inspect/HelpWizard/utils.ts               | 26 +++++++++++++++----
 2 files changed, 28 insertions(+), 11 deletions(-)

diff --git a/public/app/features/dashboard-scene/inspect/HelpWizard/SupportSnapshotService.ts b/public/app/features/dashboard-scene/inspect/HelpWizard/SupportSnapshotService.ts
index c0ea8b29591..c58e00c6667 100644
--- a/public/app/features/dashboard-scene/inspect/HelpWizard/SupportSnapshotService.ts
+++ b/public/app/features/dashboard-scene/inspect/HelpWizard/SupportSnapshotService.ts
@@ -75,12 +75,13 @@ export class SupportSnapshotService extends StateManagerBase<SupportSnapshotStat
     const snapshotSize = formattedValueToString(getValueFormat('bytes')(snapshotText?.length ?? 0));
 
     let scene: SceneObject | undefined = undefined;
-
-    try {
-      const dash = transformSaveModelToScene({ dashboard: snapshot, meta: { isEmbedded: true } });
-      scene = dash.state.body; // skip the wrappers
-    } catch (ex) {
-      console.log('Error creating scene:', ex);
+    if (snapshot) {
+      try {
+        const dash = transformSaveModelToScene({ dashboard: snapshot, meta: { isEmbedded: true } });
+        scene = dash.state.body; // skip the wrappers
+      } catch (ex) {
+        console.log('Error creating scene:', ex);
+      }
     }
 
     this.setState({ snapshot, snapshotText, markdownText, snapshotSize, snapshotUpdate: snapshotUpdate + 1, scene });
diff --git a/public/app/features/dashboard-scene/inspect/HelpWizard/utils.ts b/public/app/features/dashboard-scene/inspect/HelpWizard/utils.ts
index 1c8a2c47682..70460e97144 100644
--- a/public/app/features/dashboard-scene/inspect/HelpWizard/utils.ts
+++ b/public/app/features/dashboard-scene/inspect/HelpWizard/utils.ts
@@ -14,7 +14,8 @@ import { config } from '@grafana/runtime';
 import { SceneGridItem, VizPanel } from '@grafana/scenes';
 import { GrafanaQueryType } from 'app/plugins/datasource/grafana/types';
 
-import { gridItemToPanel } from '../../serialization/transformSceneToSaveModel';
+import { LibraryVizPanel } from '../../scene/LibraryVizPanel';
+import { gridItemToPanel, vizPanelToPanel } from '../../serialization/transformSceneToSaveModel';
 import { getQueryRunnerFor } from '../../utils/utils';
 
 import { Randomize, randomizeData } from './randomizer';
@@ -36,6 +37,7 @@ export function getPanelDataFrames(data?: PanelData): DataFrameJSON[] {
       frames.push(json);
     }
   }
+
   return frames;
 }
 
@@ -59,10 +61,20 @@ export function getGithubMarkdown(panel: VizPanel, snapshot: string): string {
 }
 
 export async function getDebugDashboard(panel: VizPanel, rand: Randomize, timeRange: TimeRange) {
-  const saveModel = gridItemToPanel(panel.parent as SceneGridItem);
+  let saveModel;
+
+  if (panel.parent instanceof LibraryVizPanel && panel.parent.parent instanceof SceneGridItem) {
+    saveModel = {
+      ...gridItemToPanel(panel.parent.parent),
+      ...vizPanelToPanel(panel),
+    };
+  } else {
+    saveModel = gridItemToPanel(panel.parent as SceneGridItem);
+  }
+
   const dashboard = cloneDeep(embeddedDataTemplate);
   const info = {
-    panelType: saveModel.type,
+    panelType: panel.state.pluginId,
     datasource: '??',
   };
 
@@ -79,6 +91,7 @@ export async function getDebugDashboard(panel: VizPanel, rand: Randomize, timeRa
   const frames = randomizeData(getPanelDataFrames(data), rand);
   const grafanaVersion = `${config.buildInfo.version} (${config.buildInfo.commit})`;
   const queries = queryRunner.state.queries ?? [];
+  const annotationsCount = data.annotations ? data.annotations.reduce((acc, c) => c.length + acc, 0) : 0;
   const html = `<table width="100%">
     <tr>
       <th width="2%">Panel</th>
@@ -119,6 +132,9 @@ export async function getDebugDashboard(panel: VizPanel, rand: Randomize, timeRa
     ],
   };
 
+  // delete library panel not to load the panel from the db
+  delete dashboard.panels[0].libraryPanel;
+
   if (saveModel.transformations?.length) {
     const last = dashboard.panels[dashboard.panels.length - 1];
     last.title = last.title + ' (after transformations)';
@@ -131,7 +147,7 @@ export async function getDebugDashboard(panel: VizPanel, rand: Randomize, timeRa
     dashboard.panels.push(before);
   }
 
-  if (data.annotations?.length) {
+  if (annotationsCount > 0) {
     dashboard.panels.push({
       id: 7,
       gridPos: {
@@ -216,7 +232,7 @@ function getAnnotationsRow(data: PanelData): string {
 
   return `<tr>
   <th>Annotations</th>
-  <td>${data.annotations.map((a, idx) => `<span>${a.length}</span>`)}</td>
+  <td>${data.annotations.reduce((acc, c) => c.length + acc, 0)}</td>
 </tr>`;
 }