IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Templating: highlight first item when searching a variable dropdown (#20264)

Browse Source
This commit is contained in:
Torkel Ödegaard 2019-11-08 09:57:32 +01:00 committed by GitHub
parent 85c4311c9f
commit ba7049dd0f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
public/app/core/directives/value_select_dropdown.ts
View File

@ -279,7 +279,7 @@ export class ValueSelectDropdownCtrl {
}
updateUIBoundOptions($scope: IScope, options: any[]) {
this.highlightIndex = -1;
this.highlightIndex = 0;
this.search.options = options.slice(0, Math.min(options.length, 1000));
$scope.$apply();
}

4
public/app/core/specs/value_select_dropdown.test.ts
View File

@ -253,8 +253,8 @@ describe('updateUIBoundOptions', () => {
ctrl.updateUIBoundOptions($scope, options);
});
it('then highlightIndex should be reset', () => {
expect(ctrl.highlightIndex).toEqual(-1);
it('then highlightIndex should be reset to first item', () => {
expect(ctrl.highlightIndex).toEqual(0);
});
it('then search.options should be same as options but capped to 1000', () => {