Chore: Report frontend metrics for JS/CSS load time (#42421)

* Report frontend metrics for js/css load time

* Add FCP metric

* Change comment

* Simplify reporting frontend metrics
This commit is contained in:
Piotr Jamróz
2021-12-02 09:34:39 +01:00
committed by GitHub
parent ee9ca20f1f
commit bb24e8d578
3 changed files with 25 additions and 17 deletions

View File

@@ -2,7 +2,6 @@ package api
import (
"net/http"
"strings"
"github.com/grafana/grafana/pkg/api/response"
"github.com/grafana/grafana/pkg/infra/metrics"
@@ -16,11 +15,10 @@ func (hs *HTTPServer) PostFrontendMetrics(c *models.ReqContext) response.Respons
return response.Error(http.StatusBadRequest, "bad request data", err)
}
for _, event := range cmd.Events {
name := strings.Replace(event.Name, "-", "_", -1)
if recorder, ok := metrics.FrontendMetrics[name]; ok {
if recorder, ok := metrics.FrontendMetrics[event.Name]; ok {
recorder(event)
} else {
c.Logger.Debug("Received unknown frontend metric", "metric", name)
c.Logger.Debug("Received unknown frontend metric", "metric", event.Name)
}
}
return response.Empty(200)

View File

@@ -39,5 +39,7 @@ func registerFrontendHistogram(name string, help string) {
func initFrontendMetrics() {
registerFrontendHistogram("frontend_boot_load_time_seconds", "Frontend boot time measurement")
registerFrontendHistogram("frontend_boot_first_paint_time_seconds", "Frontend boot first paint")
registerFrontendHistogram("frontend_boot_first_contentful_paint_time_seconds", "Frontend boot first contentful paint")
registerFrontendHistogram("frontend_boot_js_done_time_seconds", "Frontend boot initial js load")
registerFrontendHistogram("frontend_boot_css_time_seconds", "Frontend boot initial css load")
}