From bc6752a51c3114f403368bd4301b3bb3c785eab1 Mon Sep 17 00:00:00 2001
From: Ashley Harrison <ashley.harrison@grafana.com>
Date: Fri, 27 Sep 2024 15:20:45 +0100
Subject: [PATCH] SingleTopNav: Add "Grafana" header to MegaMenu (#93798)

* add "Grafana" header to MegaMenu

* add truncation for really long custom app titles

* revert padding change since paddingLeft will handle it
---
 .../components/AppChrome/AppChromeMenu.tsx    |  4 +-
 .../AppChrome/MegaMenu/MegaMenu.tsx           | 31 ++++---
 .../AppChrome/MegaMenu/MegaMenuHeader.tsx     | 85 +++++++++++++++++++
 .../AppChrome/TopBar/SingleTopBar.tsx         | 17 ++--
 4 files changed, 119 insertions(+), 18 deletions(-)
 create mode 100644 public/app/core/components/AppChrome/MegaMenu/MegaMenuHeader.tsx

diff --git a/public/app/core/components/AppChrome/AppChromeMenu.tsx b/public/app/core/components/AppChrome/AppChromeMenu.tsx
index 7926e41aae9..cf02b6a7c48 100644
--- a/public/app/core/components/AppChrome/AppChromeMenu.tsx
+++ b/public/app/core/components/AppChrome/AppChromeMenu.tsx
@@ -91,7 +91,7 @@ const getStyles = (theme: GrafanaTheme2, searchBarHidden?: boolean) => {
       left: 0,
       position: 'fixed',
       right: 0,
-      top: searchBarHidden ? 0 : TOP_BAR_LEVEL_HEIGHT,
+      top: searchBarHidden || config.featureToggles.singleTopNav ? 0 : TOP_BAR_LEVEL_HEIGHT,
       zIndex: theme.zIndex.modalBackdrop,
 
       [theme.breakpoints.up('md')]: {
@@ -107,7 +107,7 @@ const getStyles = (theme: GrafanaTheme2, searchBarHidden?: boolean) => {
       // Needs to below navbar should we change the navbarFixed? add add a new level?
       zIndex: theme.zIndex.modal,
       position: 'fixed',
-      top: searchBarHidden ? 0 : TOP_BAR_LEVEL_HEIGHT,
+      top: searchBarHidden || config.featureToggles.singleTopNav ? 0 : TOP_BAR_LEVEL_HEIGHT,
       backgroundColor: theme.colors.background.primary,
       flex: '1 1 0',
 
diff --git a/public/app/core/components/AppChrome/MegaMenu/MegaMenu.tsx b/public/app/core/components/AppChrome/MegaMenu/MegaMenu.tsx
index d7deaaeb3cd..b2be2f189b1 100644
--- a/public/app/core/components/AppChrome/MegaMenu/MegaMenu.tsx
+++ b/public/app/core/components/AppChrome/MegaMenu/MegaMenu.tsx
@@ -13,6 +13,7 @@ import { setBookmark } from 'app/core/reducers/navBarTree';
 import { usePatchUserPreferencesMutation } from 'app/features/preferences/api/index';
 import { useDispatch, useSelector } from 'app/types';
 
+import { MegaMenuHeader } from './MegaMenuHeader';
 import { MegaMenuItem } from './MegaMenuItem';
 import { usePinnedItems } from './hooks';
 import { enrichWithInteractionTracking, findByUrl, getActiveItem } from './utils';
@@ -62,6 +63,10 @@ export const MegaMenu = memo(
 
     const activeItem = getActiveItem(navItems, state.sectionNav.node, location.pathname);
 
+    const handleMegaMenu = () => {
+      chrome.setMegaMenuOpen(!state.megaMenuOpen);
+    };
+
     const handleDockedMenu = () => {
       chrome.setMegaMenuDocked(!state.megaMenuDocked);
       if (state.megaMenuDocked) {
@@ -109,22 +114,26 @@ export const MegaMenu = memo(
 
     return (
       <div data-testid={selectors.components.NavMenu.Menu} ref={ref} {...restProps}>
-        <div className={styles.mobileHeader}>
-          <Icon name="bars" size="xl" />
-          <IconButton
-            tooltip={t('navigation.megamenu.close', 'Close menu')}
-            name="times"
-            onClick={onClose}
-            size="xl"
-            variant="secondary"
-          />
-        </div>
+        {config.featureToggles.singleTopNav ? (
+          <MegaMenuHeader handleDockedMenu={handleDockedMenu} handleMegaMenu={handleMegaMenu} onClose={onClose} />
+        ) : (
+          <div className={styles.mobileHeader}>
+            <Icon name="bars" size="xl" />
+            <IconButton
+              tooltip={t('navigation.megamenu.close', 'Close menu')}
+              name="times"
+              onClick={onClose}
+              size="xl"
+              variant="secondary"
+            />
+          </div>
+        )}
         <nav className={styles.content}>
           <CustomScrollbar showScrollIndicators hideHorizontalTrack>
             <ul className={styles.itemList} aria-label={t('navigation.megamenu.list-label', 'Navigation')}>
               {navItems.map((link, index) => (
                 <Stack key={link.text} direction={index === 0 ? 'row-reverse' : 'row'} alignItems="start">
-                  {index === 0 && (
+                  {index === 0 && !config.featureToggles.singleTopNav && (
                     <IconButton
                       id="dock-menu-button"
                       className={styles.dockMenuButton}
diff --git a/public/app/core/components/AppChrome/MegaMenu/MegaMenuHeader.tsx b/public/app/core/components/AppChrome/MegaMenu/MegaMenuHeader.tsx
new file mode 100644
index 00000000000..6f0d1feeb62
--- /dev/null
+++ b/public/app/core/components/AppChrome/MegaMenu/MegaMenuHeader.tsx
@@ -0,0 +1,85 @@
+import { css } from '@emotion/css';
+
+import { GrafanaTheme2 } from '@grafana/data';
+import { IconButton, Stack, Text, ToolbarButton, useTheme2 } from '@grafana/ui';
+import { useGrafana } from 'app/core/context/GrafanaContext';
+import { t } from 'app/core/internationalization';
+
+import { Branding } from '../../Branding/Branding';
+import { TOP_BAR_LEVEL_HEIGHT } from '../types';
+
+export interface Props {
+  handleMegaMenu: () => void;
+  handleDockedMenu: () => void;
+  onClose: () => void;
+}
+
+export function MegaMenuHeader({ handleMegaMenu, handleDockedMenu, onClose }: Props) {
+  const theme = useTheme2();
+  const { chrome } = useGrafana();
+  const state = chrome.useState();
+  const styles = getStyles(theme);
+
+  return (
+    <div className={styles.header}>
+      <Stack alignItems="center" minWidth={0}>
+        <ToolbarButton narrow onClick={handleMegaMenu}>
+          <Branding.MenuLogo className={styles.img} />
+        </ToolbarButton>
+        <Text truncate>{Branding.AppTitle}</Text>
+      </Stack>
+      <IconButton
+        id="dock-menu-button"
+        className={styles.dockMenuButton}
+        tooltip={
+          state.megaMenuDocked
+            ? t('navigation.megamenu.undock', 'Undock menu')
+            : t('navigation.megamenu.dock', 'Dock menu')
+        }
+        name="web-section-alt"
+        onClick={handleDockedMenu}
+        variant="secondary"
+      />
+      <IconButton
+        className={styles.mobileCloseButton}
+        tooltip={t('navigation.megamenu.close', 'Close menu')}
+        name="times"
+        onClick={onClose}
+        size="xl"
+        variant="secondary"
+      />
+    </div>
+  );
+}
+
+MegaMenuHeader.displayName = 'MegaMenuHeader';
+
+const getStyles = (theme: GrafanaTheme2) => ({
+  dockMenuButton: css({
+    display: 'none',
+
+    [theme.breakpoints.up('xl')]: {
+      display: 'inline-flex',
+    },
+  }),
+  header: css({
+    alignItems: 'center',
+    borderBottom: `1px solid ${theme.colors.border.weak}`,
+    display: 'flex',
+    gap: theme.spacing(1),
+    justifyContent: 'space-between',
+    padding: theme.spacing(0, 1, 0, 0.5),
+    height: TOP_BAR_LEVEL_HEIGHT,
+    minHeight: TOP_BAR_LEVEL_HEIGHT,
+  }),
+  img: css({
+    alignSelf: 'center',
+    height: theme.spacing(3),
+    width: theme.spacing(3),
+  }),
+  mobileCloseButton: css({
+    [theme.breakpoints.up('md')]: {
+      display: 'none',
+    },
+  }),
+});
diff --git a/public/app/core/components/AppChrome/TopBar/SingleTopBar.tsx b/public/app/core/components/AppChrome/TopBar/SingleTopBar.tsx
index 1499882fdf9..2052979f2c8 100644
--- a/public/app/core/components/AppChrome/TopBar/SingleTopBar.tsx
+++ b/public/app/core/components/AppChrome/TopBar/SingleTopBar.tsx
@@ -5,6 +5,7 @@ import { memo } from 'react';
 import { GrafanaTheme2, NavModelItem } from '@grafana/data';
 import { Dropdown, Icon, ToolbarButton, useStyles2 } from '@grafana/ui';
 import { config } from 'app/core/config';
+import { useGrafana } from 'app/core/context/GrafanaContext';
 import { contextSrv } from 'app/core/core';
 import { HOME_NAV_ID } from 'app/core/reducers/navModel';
 import { ScopesSelector } from 'app/features/scopes';
@@ -37,7 +38,10 @@ export const SingleTopBar = memo(function SingleTopBar({
   pageNav,
   sectionNav,
 }: Props) {
-  const styles = useStyles2(getStyles);
+  const { chrome } = useGrafana();
+  const state = chrome.useState();
+  const menuDockedAndOpen = !state.chromeless && state.megaMenuDocked && state.megaMenuOpen;
+  const styles = useStyles2(getStyles, menuDockedAndOpen);
   const navIndex = useSelector((state) => state.navIndex);
 
   const helpNode = cloneDeep(navIndex['help']);
@@ -49,9 +53,11 @@ export const SingleTopBar = memo(function SingleTopBar({
   return (
     <div className={styles.layout}>
       <TopSearchBarSection>
-        <ToolbarButton narrow onClick={onToggleMegaMenu}>
-          <Branding.MenuLogo className={styles.img} />
-        </ToolbarButton>
+        {!menuDockedAndOpen && (
+          <ToolbarButton narrow onClick={onToggleMegaMenu}>
+            <Branding.MenuLogo className={styles.img} />
+          </ToolbarButton>
+        )}
         <Breadcrumbs breadcrumbs={breadcrumbs} className={styles.breadcrumbsWrapper} />
         <OrganizationSwitcher />
         <ScopesSelector />
@@ -85,13 +91,14 @@ export const SingleTopBar = memo(function SingleTopBar({
   );
 });
 
-const getStyles = (theme: GrafanaTheme2) => ({
+const getStyles = (theme: GrafanaTheme2, menuDockedAndOpen: boolean) => ({
   layout: css({
     height: TOP_BAR_LEVEL_HEIGHT,
     display: 'flex',
     gap: theme.spacing(1),
     alignItems: 'center',
     padding: theme.spacing(0, 1),
+    paddingLeft: menuDockedAndOpen ? theme.spacing(3.5) : theme.spacing(0.5),
     borderBottom: `1px solid ${theme.colors.border.weak}`,
     justifyContent: 'space-between',