From bf90ff87cf29fbe78daabba7d2450b499bf08ae5 Mon Sep 17 00:00:00 2001 From: Mario Trangoni Date: Sat, 26 Jan 2019 14:23:10 +0100 Subject: [PATCH] pkg/services/dashboards/dashboard_service.go: simplify return See, $ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./... pkg/services/dashboards/dashboard_service.go:167:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (megacheck) --- pkg/services/dashboards/dashboard_service.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/pkg/services/dashboards/dashboard_service.go b/pkg/services/dashboards/dashboard_service.go index 59ceefa0be5..33f418cbee3 100644 --- a/pkg/services/dashboards/dashboard_service.go +++ b/pkg/services/dashboards/dashboard_service.go @@ -164,11 +164,7 @@ func (dr *dashboardServiceImpl) updateAlerting(cmd *models.SaveDashboardCommand, User: dto.User, } - if err := bus.Dispatch(&alertCmd); err != nil { - return err - } - - return nil + return bus.Dispatch(&alertCmd) } func (dr *dashboardServiceImpl) SaveProvisionedDashboard(dto *SaveDashboardDTO, provisioning *models.DashboardProvisioning) (*models.Dashboard, error) {