From c00c8db13c0cf3359c9486f8f15f932161cb90c8 Mon Sep 17 00:00:00 2001
From: Nathan Marrs <nathanielmarrs@gmail.com>
Date: Mon, 1 Aug 2022 19:32:41 -0600
Subject: [PATCH] Canvas: Unable to add fixed text in textbox element #53080

---
 .../dimensions/editors/TextDimensionEditor.tsx      | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/public/app/features/dimensions/editors/TextDimensionEditor.tsx b/public/app/features/dimensions/editors/TextDimensionEditor.tsx
index 66e7365504c..a74ecfa0477 100644
--- a/public/app/features/dimensions/editors/TextDimensionEditor.tsx
+++ b/public/app/features/dimensions/editors/TextDimensionEditor.tsx
@@ -59,12 +59,15 @@ export const TextDimensionEditor: FC<StandardEditorProps<TextDimensionConfig, Te
         ...value,
         fixed,
       });
-
-      setRefresh(refresh + 1);
     },
-    [onChange, refresh, value]
+    [onChange, value]
   );
 
+  const onClearFixed = () => {
+    onFixedChange('');
+    setRefresh(refresh + 1);
+  };
+
   const mode = value?.mode ?? TextDimensionMode.Fixed;
 
   return (
@@ -95,9 +98,7 @@ export const TextDimensionEditor: FC<StandardEditorProps<TextDimensionConfig, Te
               onChange={onFixedChange}
               item={dummyStringSettings}
               suffix={
-                value?.fixed && (
-                  <Button icon="times" variant="secondary" fill="text" size="sm" onClick={() => onFixedChange('')} />
-                )
+                value?.fixed && <Button icon="times" variant="secondary" fill="text" size="sm" onClick={onClearFixed} />
               }
             />
           </InlineField>