IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-10 07:35:45 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: revise some of the gosec rules (#16713)

Browse Source
This commit is contained in:
Oleg Gaidarenko 2019-05-01 12:36:02 +03:00 committed by Carl Bergquist
parent 51a98565dc
commit c1289b308f
4 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/cmd/grafana-cli/commands/install_command.go
View File

@ -144,7 +144,7 @@ func downloadFile(pluginName, filePath, url string) (err error) {
} }
}() }()
resp, err := http.Get(url) resp, err := http.Get(url) // #nosec
if err != nil { if err != nil {
return err return err
} }
@ -167,7 +167,7 @@ func extractFiles(body []byte, pluginName string, filePath string) error {
newFile := path.Join(filePath, RemoveGitBuildFromName(pluginName, zf.Name)) newFile := path.Join(filePath, RemoveGitBuildFromName(pluginName, zf.Name))
if zf.FileInfo().IsDir() { if zf.FileInfo().IsDir() {
err := os.Mkdir(newFile, 0777) err := os.Mkdir(newFile, 0755)
if permissionsError(err) { if permissionsError(err) {
return fmt.Errorf(permissionsDeniedMessage, newFile) return fmt.Errorf(permissionsDeniedMessage, newFile)
} }

1
pkg/services/notifications/codes.go
View File

@ -7,6 +7,7 @@ import (
"time" "time"
"github.com/Unknwon/com" "github.com/Unknwon/com"
m "github.com/grafana/grafana/pkg/models" m "github.com/grafana/grafana/pkg/models"
"github.com/grafana/grafana/pkg/setting" "github.com/grafana/grafana/pkg/setting"
) )

5
scripts/backend-lint.sh
View File

@ -39,4 +39,7 @@ exit_if_fail go vet ./pkg/...
exit_if_fail revive -formatter stylish -config ./scripts/revive.toml exit_if_fail revive -formatter stylish -config ./scripts/revive.toml
# TODO recheck the rules and leave only necessary exclusions # TODO recheck the rules and leave only necessary exclusions
#exit_if_fail gosec -quiet -exclude=G104,G107,G201,G202,G204,G301,G302,G304,G402,G501,G505,G401 ./pkg/... # exit_if_fail gosec -quiet \
# -exclude=G104,G107,G201,G202,G204,G301,G304,G401,G402,G501 \
# -conf=./scripts/gosec.json \
# ./pkg/...

4
scripts/gosec.json Normal file
View File

@ -0,0 +1,4 @@
{
"G302": "0660",
"G301": "0755"
}