From c138b04c5e07660a2cc38f284c9cc8160e384dd1 Mon Sep 17 00:00:00 2001 From: bergquist Date: Thu, 3 Nov 2016 07:25:00 +0100 Subject: [PATCH] feat(alerting): avoid double logging --- pkg/services/alerting/extractor.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/services/alerting/extractor.go b/pkg/services/alerting/extractor.go index 3ab1c32972a..786fae846ad 100644 --- a/pkg/services/alerting/extractor.go +++ b/pkg/services/alerting/extractor.go @@ -3,6 +3,8 @@ package alerting import ( "errors" + "fmt" + "github.com/grafana/grafana/pkg/bus" "github.com/grafana/grafana/pkg/components/simplejson" "github.com/grafana/grafana/pkg/log" @@ -104,8 +106,8 @@ func (e *DashAlertExtractor) GetAlerts() ([]*m.Alert, error) { panelQuery := findPanelQueryByRefId(panel, queryRefId) if panelQuery == nil { - e.log.Error("Query not found", "panel", alert.PanelId, "queryRefId", queryRefId) - return nil, ValidationError{Reason: "Alert refers to query that cannot be found"} + reason := fmt.Sprintf("Alert on PanelId: %v refers to query(%s) that cannot be found", alert.PanelId, queryRefId) + return nil, ValidationError{Reason: reason} } dsName := ""