IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

ShareDrawer: Enable by default (#97259)

Browse Source
This commit is contained in:
Juan Cabanas 2024-12-10 12:52:18 -03:00 committed by GitHub
parent e6a6b3e31a
commit c2333e3bc0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
View File

@ -70,7 +70,7 @@ Most [generally available](https://grafana.com/docs/release-life-cycle/#general-
| `tlsMemcached` | Use TLS-enabled memcached in the enterprise caching feature | Yes |
| `cloudWatchNewLabelParsing` | Updates CloudWatch label parsing to be more accurate | Yes |
| `accessActionSets` | Introduces action sets for resource permissions. Also ensures that all folder editors and admins can create subfolders without needing any additional permissions. | Yes |
| `newDashboardSharingComponent` | Enables the new sharing drawer design | |
| `newDashboardSharingComponent` | Enables the new sharing drawer design | Yes |
| `notificationBanner` | Enables the notification banner UI and API | Yes |
| `pluginProxyPreserveTrailingSlash` | Preserve plugin proxy trailing slash. | |
| `pinNavItems` | Enables pinning of nav items | Yes |

2
e2e/dashboards-suite/dashboard-public-templating.spec.ts
View File

@ -7,7 +7,7 @@ describe('Create a public dashboard with template variables shows a template var
it('Create a public dashboard with template variables shows a template variable warning', () => {
// Opening a dashboard with template variables
e2e.flows.openDashboard({ uid: 'HYaGDGIMk' });
e2e.flows.openDashboard({ uid: 'HYaGDGIMk', queryParams: { '__feature.newDashboardSharingComponent': false } });
// Open sharing modal
e2e.components.NavToolbar.shareDashboard().click();

2
e2e/dashboards-suite/snapshot-create.spec.ts
View File

@ -10,7 +10,7 @@ describe('Snapshots', () => {
cy.intercept({
pathname: '/api/ds/query',
}).as('query');
e2e.flows.openDashboard({ uid: 'ZqZnVvFZz' });
e2e.flows.openDashboard({ uid: 'ZqZnVvFZz', queryParams: { '__feature.newDashboardSharingComponent': false } });
cy.wait('@query');
const panelsToCheck = [

2
pkg/services/featuremgmt/registry.go
View File

@ -1248,7 +1248,7 @@ var (
Stage: FeatureStageGeneralAvailability,
Owner: grafanaSharingSquad,
FrontendOnly: true,
Expression: "false", // disabled by default
Expression: "true", // enabled by default
},
{
Name: "alertingListViewV2",

6
pkg/services/featuremgmt/toggles_gen.json
View File

@ -2327,10 +2327,10 @@
{
"metadata": {
"name": "newDashboardSharingComponent",
"resourceVersion": "1726241874335",
"resourceVersion": "1733231733564",
"creationTimestamp": "2024-05-03T15:02:18Z",
"annotations": {
"grafana.app/updatedTimestamp": "2024-09-13 15:37:54.335099 +0000 UTC"
"grafana.app/updatedTimestamp": "2024-12-03 13:15:33.564083 +0000 UTC"
}
},
"spec": {
@ -2338,7 +2338,7 @@
"stage": "GA",
"codeowner": "@grafana/sharing-squad",
"frontend": true,
"expression": "false"
"expression": "true"
}
},
{

7
public/app/features/dashboard-scene/sharing/ShareButton/ShareButton.tsx
View File

@ -46,7 +46,12 @@ export default function ShareButton({ dashboard, panel }: { dashboard: Dashboard
<Trans i18nKey="share-dashboard.share-button">Share</Trans>
</Button>
<Dropdown overlay={MenuActions} placement="bottom-end" onVisibleChange={onMenuClick}>
<Button data-testid={newShareButtonSelector.arrowMenu} size="sm" icon={isOpen ? 'angle-up' : 'angle-down'} />
<Button
aria-label="share-dropdown-menu"
data-testid={newShareButtonSelector.arrowMenu}
size="sm"
icon={isOpen ? 'angle-up' : 'angle-down'}
/>
</Dropdown>
</ButtonGroup>
);