Navigation: always show GetStartedWithPlugin even if there's install control wa… (#59127)

always show `GetStartedWithPlugin` even if there's install control warnings
This commit is contained in:
Ashley Harrison 2022-11-23 11:34:00 +00:00 committed by GitHub
parent 0af96936be
commit c2f31c2685
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -17,17 +17,19 @@ export const PluginActions = ({ plugin }: Props) => {
const isRemotePluginsAvailable = useIsRemotePluginsAvailable(); const isRemotePluginsAvailable = useIsRemotePluginsAvailable();
const latestCompatibleVersion = getLatestCompatibleVersion(plugin?.details?.versions); const latestCompatibleVersion = getLatestCompatibleVersion(plugin?.details?.versions);
if (!plugin || hasInstallControlWarning(plugin, isRemotePluginsAvailable, latestCompatibleVersion)) { if (!plugin) {
return null; return null;
} }
const hasInstallWarning = hasInstallControlWarning(plugin, isRemotePluginsAvailable, latestCompatibleVersion);
const isExternallyManaged = config.pluginAdminExternalManageEnabled; const isExternallyManaged = config.pluginAdminExternalManageEnabled;
const pluginStatus = plugin.isInstalled const pluginStatus = plugin.isInstalled
? plugin.hasUpdate ? plugin.hasUpdate
? PluginStatus.UPDATE ? PluginStatus.UPDATE
: PluginStatus.UNINSTALL : PluginStatus.UNINSTALL
: PluginStatus.INSTALL; : PluginStatus.INSTALL;
const isInstallControlsDisabled = plugin.isCore || plugin.isDisabled || !isInstallControlsEnabled(); const isInstallControlsDisabled =
plugin.isCore || plugin.isDisabled || !isInstallControlsEnabled() || hasInstallWarning;
return ( return (
<> <>