From c3a8590fe5f5cad71b3e68bea55ccdd834840931 Mon Sep 17 00:00:00 2001
From: Gilles De Mey <gilles.de.mey@gmail.com>
Date: Thu, 1 Dec 2022 17:05:28 +0100
Subject: [PATCH] Alerting: Reduce number of buildinfo calls (#59319)

---
 .../src/components/DataSourcePicker.test.tsx    |  9 ++++++++-
 .../src/components/DataSourcePicker.tsx         | 16 +++++++++++++++-
 .../features/alerting/unified/RuleEditor.tsx    | 12 +++++++-----
 .../rule-editor/CloudRulesSourcePicker.tsx      | 17 ++++++++++++++++-
 .../rule-editor/rule-types/RuleTypePicker.tsx   |  8 +++++++-
 .../features/alerting/unified/state/actions.ts  |  1 +
 6 files changed, 54 insertions(+), 9 deletions(-)

diff --git a/packages/grafana-runtime/src/components/DataSourcePicker.test.tsx b/packages/grafana-runtime/src/components/DataSourcePicker.test.tsx
index e41eaeaa4f0..bdd44487e7b 100644
--- a/packages/grafana-runtime/src/components/DataSourcePicker.test.tsx
+++ b/packages/grafana-runtime/src/components/DataSourcePicker.test.tsx
@@ -1,4 +1,4 @@
-import { render } from '@testing-library/react';
+import { render, screen } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import React from 'react';
 
@@ -24,5 +24,12 @@ describe('DataSourcePicker', () => {
         select.getByLabelText('select-clear-value');
       }).toThrowError();
     });
+
+    it('should pass disabled prop', async () => {
+      render(<DataSourcePicker disabled={true} />);
+
+      const input = screen.getByLabelText('Select a data source');
+      expect(input).toHaveProperty('disabled', true);
+    });
   });
 });
diff --git a/packages/grafana-runtime/src/components/DataSourcePicker.tsx b/packages/grafana-runtime/src/components/DataSourcePicker.tsx
index 0ceba9231be..b9ad9c2b761 100644
--- a/packages/grafana-runtime/src/components/DataSourcePicker.tsx
+++ b/packages/grafana-runtime/src/components/DataSourcePicker.tsx
@@ -47,6 +47,8 @@ export interface DataSourcePickerProps {
   filter?: (dataSource: DataSourceInstanceSettings) => boolean;
   onClear?: () => void;
   invalid?: boolean;
+  disabled?: boolean;
+  isLoading?: boolean;
 }
 
 /**
@@ -162,7 +164,17 @@ export class DataSourcePicker extends PureComponent<DataSourcePickerProps, DataS
   }
 
   render() {
-    const { autoFocus, onBlur, onClear, openMenuOnFocus, placeholder, width, inputId } = this.props;
+    const {
+      autoFocus,
+      onBlur,
+      onClear,
+      openMenuOnFocus,
+      placeholder,
+      width,
+      inputId,
+      disabled = false,
+      isLoading = false,
+    } = this.props;
     const { error } = this.state;
     const options = this.getDataSourceOptions();
     const value = this.getCurrentValue();
@@ -171,6 +183,8 @@ export class DataSourcePicker extends PureComponent<DataSourcePickerProps, DataS
     return (
       <div aria-label={selectors.components.DataSourcePicker.container}>
         <Select
+          isLoading={isLoading}
+          disabled={disabled}
           aria-label={selectors.components.DataSourcePicker.inputV2}
           inputId={inputId || 'data-source-picker'}
           className="ds-picker select-container"
diff --git a/public/app/features/alerting/unified/RuleEditor.tsx b/public/app/features/alerting/unified/RuleEditor.tsx
index db9788cf626..bc461f500ef 100644
--- a/public/app/features/alerting/unified/RuleEditor.tsx
+++ b/public/app/features/alerting/unified/RuleEditor.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { useCallback } from 'react';
 import { useAsync } from 'react-use';
 
 import { NavModelItem } from '@grafana/data';
@@ -12,7 +12,7 @@ import { ExistingRuleEditor } from './ExistingRuleEditor';
 import { AlertingPageWrapper } from './components/AlertingPageWrapper';
 import { AlertRuleForm } from './components/rule-editor/AlertRuleForm';
 import { useURLSearchParams } from './hooks/useURLSearchParams';
-import { fetchAllPromBuildInfoAction } from './state/actions';
+import { fetchRulesSourceBuildInfoAction } from './state/actions';
 import { useRulesAccess } from './utils/accessControlHooks';
 import * as ruleId from './utils/rule-id';
 
@@ -44,12 +44,14 @@ const RuleEditor = ({ match }: RuleEditorProps) => {
   const copyFromIdentifier = ruleId.tryParse(copyFromId);
 
   const { loading = true } = useAsync(async () => {
-    await dispatch(fetchAllPromBuildInfoAction());
+    if (identifier) {
+      await dispatch(fetchRulesSourceBuildInfoAction({ rulesSourceName: identifier.ruleSourceName }));
+    }
   }, [dispatch]);
 
   const { canCreateGrafanaRules, canCreateCloudRules, canEditRules } = useRulesAccess();
 
-  const getContent = () => {
+  const getContent = useCallback(() => {
     if (loading) {
       return;
     }
@@ -71,7 +73,7 @@ const RuleEditor = ({ match }: RuleEditorProps) => {
     }
 
     return <AlertRuleForm />;
-  };
+  }, [canCreateCloudRules, canCreateGrafanaRules, canEditRules, copyFromIdentifier, id, identifier, loading]);
 
   return (
     <AlertingPageWrapper isLoading={loading} pageId="alert-list" pageNav={getPageNav(identifier ? 'edit' : 'add')}>
diff --git a/public/app/features/alerting/unified/components/rule-editor/CloudRulesSourcePicker.tsx b/public/app/features/alerting/unified/components/rule-editor/CloudRulesSourcePicker.tsx
index b995cdfdd49..0b255db5692 100644
--- a/public/app/features/alerting/unified/components/rule-editor/CloudRulesSourcePicker.tsx
+++ b/public/app/features/alerting/unified/components/rule-editor/CloudRulesSourcePicker.tsx
@@ -1,9 +1,12 @@
 import React, { useCallback } from 'react';
+import { useAsync } from 'react-use';
 
 import { DataSourceInstanceSettings } from '@grafana/data';
 import { DataSourcePicker } from '@grafana/runtime';
+import { dispatch } from 'app/store/store';
 
 import { useRulesSourcesWithRuler } from '../../hooks/useRuleSourcesWithRuler';
+import { fetchAllPromBuildInfoAction } from '../../state/actions';
 
 interface Props {
   onChange: (ds: DataSourceInstanceSettings) => void;
@@ -15,6 +18,8 @@ interface Props {
 export function CloudRulesSourcePicker({ value, ...props }: Props): JSX.Element {
   const rulesSourcesWithRuler = useRulesSourcesWithRuler();
 
+  const { loading = true } = useAsync(() => dispatch(fetchAllPromBuildInfoAction()), [dispatch]);
+
   const dataSourceFilter = useCallback(
     (ds: DataSourceInstanceSettings): boolean => {
       return !!rulesSourcesWithRuler.find(({ id }) => id === ds.id);
@@ -22,5 +27,15 @@ export function CloudRulesSourcePicker({ value, ...props }: Props): JSX.Element
     [rulesSourcesWithRuler]
   );
 
-  return <DataSourcePicker noDefault alerting filter={dataSourceFilter} current={value} {...props} />;
+  return (
+    <DataSourcePicker
+      disabled={loading}
+      isLoading={loading}
+      noDefault
+      alerting
+      filter={dataSourceFilter}
+      current={value}
+      {...props}
+    />
+  );
 }
diff --git a/public/app/features/alerting/unified/components/rule-editor/rule-types/RuleTypePicker.tsx b/public/app/features/alerting/unified/components/rule-editor/rule-types/RuleTypePicker.tsx
index f92eaede6a1..f92f1973e86 100644
--- a/public/app/features/alerting/unified/components/rule-editor/rule-types/RuleTypePicker.tsx
+++ b/public/app/features/alerting/unified/components/rule-editor/rule-types/RuleTypePicker.tsx
@@ -1,12 +1,14 @@
 import { css } from '@emotion/css';
 import { isEmpty } from 'lodash';
-import React, { FC } from 'react';
+import React, { FC, useEffect } from 'react';
 
 import { GrafanaTheme2 } from '@grafana/data/src';
 import { Stack } from '@grafana/experimental';
 import { useStyles2 } from '@grafana/ui';
+import { dispatch } from 'app/store/store';
 
 import { useRulesSourcesWithRuler } from '../../../hooks/useRuleSourcesWithRuler';
+import { fetchAllPromBuildInfoAction } from '../../../state/actions';
 import { RuleFormType } from '../../../types/rule-form';
 
 import { GrafanaManagedRuleType } from './GrafanaManagedAlert';
@@ -23,6 +25,10 @@ const RuleTypePicker: FC<RuleTypePickerProps> = ({ selected, onChange, enabledTy
   const rulesSourcesWithRuler = useRulesSourcesWithRuler();
   const hasLotexDatasources = !isEmpty(rulesSourcesWithRuler);
 
+  useEffect(() => {
+    dispatch(fetchAllPromBuildInfoAction());
+  }, []);
+
   const styles = useStyles2(getStyles);
 
   return (
diff --git a/public/app/features/alerting/unified/state/actions.ts b/public/app/features/alerting/unified/state/actions.ts
index b2ed0b227ed..187983368b1 100644
--- a/public/app/features/alerting/unified/state/actions.ts
+++ b/public/app/features/alerting/unified/state/actions.ts
@@ -263,6 +263,7 @@ export function fetchRulerRulesIfNotFetchedYet(rulesSourceName: string): ThunkRe
   };
 }
 
+// TODO: memoize this or move to RTK Query so we can cache results!
 export function fetchAllPromBuildInfoAction(): ThunkResult<Promise<void>> {
   return async (dispatch) => {
     const allRequests = getAllRulesSourceNames().map((rulesSourceName) =>